diff options
author | Yevhen Orlov <yevhen.orlov@plvision.eu> | 2022-01-11 03:10:51 +0200 |
---|---|---|
committer | Jakub Kicinski <kuba@kernel.org> | 2022-01-12 10:17:04 -0800 |
commit | 32d098bb2e494cf282968ae654dadf7299bb73b0 (patch) | |
tree | 9d106922b23d8c49d4e31f31f790f64e0a68ef34 /drivers/net/ethernet/marvell/prestera/prestera_router_hw.c | |
parent | 6a1ba8758f67e37a48fd2f940032a2b186bcf021 (diff) | |
download | linux-stable-32d098bb2e494cf282968ae654dadf7299bb73b0.tar.gz linux-stable-32d098bb2e494cf282968ae654dadf7299bb73b0.tar.bz2 linux-stable-32d098bb2e494cf282968ae654dadf7299bb73b0.zip |
net: marvell: prestera: Refactor router functions
* Reverse xmas tree variables order
* User friendly messages on error paths
* Refactor __prestera_inetaddr_event to use early return
Signed-off-by: Yevhen Orlov <yevhen.orlov@plvision.eu>
Link: https://lore.kernel.org/r/20220111011051.4941-1-yevhen.orlov@plvision.eu
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Diffstat (limited to 'drivers/net/ethernet/marvell/prestera/prestera_router_hw.c')
-rw-r--r-- | drivers/net/ethernet/marvell/prestera/prestera_router_hw.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/ethernet/marvell/prestera/prestera_router_hw.c b/drivers/net/ethernet/marvell/prestera/prestera_router_hw.c index d5befd1d1440..490e9b61fd8d 100644 --- a/drivers/net/ethernet/marvell/prestera/prestera_router_hw.c +++ b/drivers/net/ethernet/marvell/prestera/prestera_router_hw.c @@ -123,7 +123,7 @@ __prestera_rif_entry_key_copy(const struct prestera_rif_entry_key *in, out->iface.vlan_id = in->iface.vlan_id; break; default: - pr_err("Unsupported iface type"); + WARN(1, "Unsupported iface type"); return -EINVAL; } |