diff options
| author | Tom Rix <trix@redhat.com> | 2022-01-15 09:49:18 -0800 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2022-01-15 22:33:17 +0000 |
| commit | 214b3369ab9b0a6f28d6c970220c209417edbc65 (patch) | |
| tree | b673945c3500d3657d349d6a607345a2febb66dc /drivers/net/ethernet/mediatek/mtk_eth_soc.c | |
| parent | 80f15f3bef9e9c2cc29888a6773df44de0a0c65f (diff) | |
| download | linux-stable-214b3369ab9b0a6f28d6c970220c209417edbc65.tar.gz linux-stable-214b3369ab9b0a6f28d6c970220c209417edbc65.tar.bz2 linux-stable-214b3369ab9b0a6f28d6c970220c209417edbc65.zip | |
net: ethernet: mtk_eth_soc: fix error checking in mtk_mac_config()
Clang static analysis reports this problem
mtk_eth_soc.c:394:7: warning: Branch condition evaluates
to a garbage value
if (err)
^~~
err is not initialized and only conditionally set.
So intitialize err.
Fixes: 7e538372694b ("net: ethernet: mediatek: Re-add support SGMII")
Signed-off-by: Tom Rix <trix@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/mediatek/mtk_eth_soc.c')
| -rw-r--r-- | drivers/net/ethernet/mediatek/mtk_eth_soc.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/ethernet/mediatek/mtk_eth_soc.c b/drivers/net/ethernet/mediatek/mtk_eth_soc.c index b67b4323cff0..f02d07ec5ccb 100644 --- a/drivers/net/ethernet/mediatek/mtk_eth_soc.c +++ b/drivers/net/ethernet/mediatek/mtk_eth_soc.c @@ -267,7 +267,7 @@ static void mtk_mac_config(struct phylink_config *config, unsigned int mode, phylink_config); struct mtk_eth *eth = mac->hw; u32 mcr_cur, mcr_new, sid, i; - int val, ge_mode, err; + int val, ge_mode, err = 0; /* MT76x8 has no hardware settings between for the MAC */ if (!MTK_HAS_CAPS(eth->soc->caps, MTK_SOC_MT7628) && |