diff options
| author | Colin Ian King <colin.king@canonical.com> | 2020-06-30 16:16:46 +0100 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2020-06-30 13:38:47 -0700 |
| commit | 5831b33362fdb60d56314a237b764e24ee1a538e (patch) | |
| tree | 28adbb2dc388234dfaa35b3d773610473f05e012 /drivers/net/ethernet/mellanox/mlx5/core/en_accel/tls.c | |
| parent | 6bad912b7e5ab51c23d8fa8362ca2d4ceeebdb74 (diff) | |
| download | linux-stable-5831b33362fdb60d56314a237b764e24ee1a538e.tar.gz linux-stable-5831b33362fdb60d56314a237b764e24ee1a538e.tar.bz2 linux-stable-5831b33362fdb60d56314a237b764e24ee1a538e.zip | |
net/mlx5e: fix memory leak of tls
The error return path when create_singlethread_workqueue fails currently
does not kfree tls and leads to a memory leak. Fix this by kfree'ing
tls before returning -ENOMEM.
Addresses-Coverity: ("Resource leak")
Fixes: 1182f3659357 ("net/mlx5e: kTLS, Add kTLS RX HW offload support")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Tariq Toukan <tariqt@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/mellanox/mlx5/core/en_accel/tls.c')
| -rw-r--r-- | drivers/net/ethernet/mellanox/mlx5/core/en_accel/tls.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_accel/tls.c b/drivers/net/ethernet/mellanox/mlx5/core/en_accel/tls.c index 99beb928feff..fee991f5ee7c 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/en_accel/tls.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_accel/tls.c @@ -232,8 +232,10 @@ int mlx5e_tls_init(struct mlx5e_priv *priv) return -ENOMEM; tls->rx_wq = create_singlethread_workqueue("mlx5e_tls_rx"); - if (!tls->rx_wq) + if (!tls->rx_wq) { + kfree(tls); return -ENOMEM; + } priv->tls = tls; return 0; |