summaryrefslogtreecommitdiffstats
path: root/drivers/net/ethernet/mellanox/mlx5
diff options
context:
space:
mode:
authorGal Pressman <galp@mellanox.com>2017-06-19 18:25:59 +0300
committerSaeed Mahameed <saeedm@mellanox.com>2017-06-27 14:49:57 +0300
commit8ce59b16b4b6eacedaec1f7b652b4781cdbfe15f (patch)
tree3cda6fb92a083a3e09244adc596e140f2e51c09e /drivers/net/ethernet/mellanox/mlx5
parentd747a7a51b00984127a88113cdbbc26f91e9d815 (diff)
downloadlinux-stable-8ce59b16b4b6eacedaec1f7b652b4781cdbfe15f.tar.gz
linux-stable-8ce59b16b4b6eacedaec1f7b652b4781cdbfe15f.tar.bz2
linux-stable-8ce59b16b4b6eacedaec1f7b652b4781cdbfe15f.zip
net/mlx5: Fix driver load error flow when firmware is stuck
When wait for firmware init fails, previous code would mistakenly return success and cause inconsistency in the driver state. Fixes: 6c780a0267b8 ("net/mlx5: Wait for FW readiness before initializing command interface") Signed-off-by: Gal Pressman <galp@mellanox.com> Signed-off-by: Saeed Mahameed <saeedm@mellanox.com>
Diffstat (limited to 'drivers/net/ethernet/mellanox/mlx5')
-rw-r--r--drivers/net/ethernet/mellanox/mlx5/core/main.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/main.c b/drivers/net/ethernet/mellanox/mlx5/core/main.c
index 13be264587f1..fd47b5134841 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/main.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/main.c
@@ -1020,7 +1020,7 @@ static int mlx5_load_one(struct mlx5_core_dev *dev, struct mlx5_priv *priv,
if (err) {
dev_err(&dev->pdev->dev, "Firmware over %d MS in pre-initializing state, aborting\n",
FW_PRE_INIT_TIMEOUT_MILI);
- goto out;
+ goto out_err;
}
err = mlx5_cmd_init(dev);