diff options
author | Zhengchao Shao <shaozhengchao@huawei.com> | 2023-06-30 09:26:47 +0800 |
---|---|---|
committer | Jakub Kicinski <kuba@kernel.org> | 2023-06-29 19:10:07 -0700 |
commit | 08fc75735fda3be97194bfbf3c899c87abb3d0fe (patch) | |
tree | 0ea9b66be4db5c982e0002bbfa3f5bbcfdf6e7fa /drivers/net/ethernet/mellanox/mlxsw/minimal.c | |
parent | 3cf62c8177adb0db9e15c8b898c44f997acf3ebf (diff) | |
download | linux-stable-08fc75735fda3be97194bfbf3c899c87abb3d0fe.tar.gz linux-stable-08fc75735fda3be97194bfbf3c899c87abb3d0fe.tar.bz2 linux-stable-08fc75735fda3be97194bfbf3c899c87abb3d0fe.zip |
mlxsw: minimal: fix potential memory leak in mlxsw_m_linecards_init
The line cards array is not freed in the error path of
mlxsw_m_linecards_init(), which can lead to a memory leak. Fix by
freeing the array in the error path, thereby making the error path
identical to mlxsw_m_linecards_fini().
Fixes: 01328e23a476 ("mlxsw: minimal: Extend module to port mapping with slot index")
Signed-off-by: Zhengchao Shao <shaozhengchao@huawei.com>
Reviewed-by: Petr Machata <petrm@nvidia.com>
Reviewed-by: Ido Schimmel <idosch@nvidia.com>
Link: https://lore.kernel.org/r/20230630012647.1078002-1-shaozhengchao@huawei.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Diffstat (limited to 'drivers/net/ethernet/mellanox/mlxsw/minimal.c')
-rw-r--r-- | drivers/net/ethernet/mellanox/mlxsw/minimal.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/net/ethernet/mellanox/mlxsw/minimal.c b/drivers/net/ethernet/mellanox/mlxsw/minimal.c index 6b56eadd736e..6b98c3287b49 100644 --- a/drivers/net/ethernet/mellanox/mlxsw/minimal.c +++ b/drivers/net/ethernet/mellanox/mlxsw/minimal.c @@ -417,6 +417,7 @@ static int mlxsw_m_linecards_init(struct mlxsw_m *mlxsw_m) err_kmalloc_array: for (i--; i >= 0; i--) kfree(mlxsw_m->line_cards[i]); + kfree(mlxsw_m->line_cards); err_kcalloc: kfree(mlxsw_m->ports); return err; |