diff options
| author | Pavithra Sathyanarayanan <Pavithra.Sathyanarayanan@microchip.com> | 2023-09-14 11:47:37 +0530 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2023-09-17 11:52:58 +0100 |
| commit | 1e73cfe859523236e6e29167673fc2885f1b99c4 (patch) | |
| tree | 453c023e7602cbdce4c9862458a2bd13dce5ff12 /drivers/net/ethernet/microchip | |
| parent | 037dbd122d0e223b2dbfe4333bce8274f5ab96d5 (diff) | |
| download | linux-stable-1e73cfe859523236e6e29167673fc2885f1b99c4.tar.gz linux-stable-1e73cfe859523236e6e29167673fc2885f1b99c4.tar.bz2 linux-stable-1e73cfe859523236e6e29167673fc2885f1b99c4.zip | |
net: microchip: lan743x: add fixed phy unregister support
When operating in fixed phy mode and if there is repeated open/close
phy test cases, everytime the fixed phy is registered as a new phy
which leads to overrun after 32 iterations. It is solved by adding
fixed_phy_unregister() in the phy_close path.
In phy_close path, netdev->phydev cannot be used directly in
fixed_phy_unregister() due to two reasons,
- netdev->phydev is set to NULL in phy_disconnect()
- fixed_phy_unregister() can be called only after phy_disconnect()
So saving the netdev->phydev in local variable 'phydev' and
passing it to phy_disconnect().
Signed-off-by: Pavithra Sathyanarayanan <Pavithra.Sathyanarayanan@microchip.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/microchip')
| -rw-r--r-- | drivers/net/ethernet/microchip/lan743x_main.c | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/drivers/net/ethernet/microchip/lan743x_main.c b/drivers/net/ethernet/microchip/lan743x_main.c index c81cdeb4d4e7..f940895b14e8 100644 --- a/drivers/net/ethernet/microchip/lan743x_main.c +++ b/drivers/net/ethernet/microchip/lan743x_main.c @@ -1466,9 +1466,15 @@ static void lan743x_phy_link_status_change(struct net_device *netdev) static void lan743x_phy_close(struct lan743x_adapter *adapter) { struct net_device *netdev = adapter->netdev; + struct phy_device *phydev = netdev->phydev; phy_stop(netdev->phydev); phy_disconnect(netdev->phydev); + + /* using phydev here as phy_disconnect NULLs netdev->phydev */ + if (phy_is_pseudo_fixed_link(phydev)) + fixed_phy_unregister(phydev); + } static void lan743x_phy_interface_select(struct lan743x_adapter *adapter) |