diff options
| author | Wolfram Sang <wsa+renesas@sang-engineering.com> | 2023-03-21 07:58:26 +0100 |
|---|---|---|
| committer | Paolo Abeni <pabeni@redhat.com> | 2023-03-22 13:23:57 +0100 |
| commit | ce1fdb065695f49ef6f126d35c1abbfe645d62d5 (patch) | |
| tree | a694abf20267a7a93c02d6e8edc7aab9b85408fb /drivers/net/ethernet/renesas | |
| parent | 7849c42da2ca09f11fe04aeb8dbde63df756edaa (diff) | |
| download | linux-stable-ce1fdb065695f49ef6f126d35c1abbfe645d62d5.tar.gz linux-stable-ce1fdb065695f49ef6f126d35c1abbfe645d62d5.tar.bz2 linux-stable-ce1fdb065695f49ef6f126d35c1abbfe645d62d5.zip | |
sh_eth: remove open coded netif_running()
It had a purpose back in the days, but today we have a handy helper.
Reported-by: Geert Uytterhoeven <geert+renesas@glider.be>
Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Reviewed-by: Leon Romanovsky <leonro@nvidia.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Tested-by: Geert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
Link: https://lore.kernel.org/r/20230321065826.2044-1-wsa+renesas@sang-engineering.com
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
Diffstat (limited to 'drivers/net/ethernet/renesas')
| -rw-r--r-- | drivers/net/ethernet/renesas/sh_eth.c | 6 | ||||
| -rw-r--r-- | drivers/net/ethernet/renesas/sh_eth.h | 1 |
2 files changed, 1 insertions, 6 deletions
diff --git a/drivers/net/ethernet/renesas/sh_eth.c b/drivers/net/ethernet/renesas/sh_eth.c index d8ec729825be..2d9787231099 100644 --- a/drivers/net/ethernet/renesas/sh_eth.c +++ b/drivers/net/ethernet/renesas/sh_eth.c @@ -2441,8 +2441,6 @@ static int sh_eth_open(struct net_device *ndev) netif_start_queue(ndev); - mdp->is_opened = 1; - return ret; out_free_irq: @@ -2565,7 +2563,7 @@ static struct net_device_stats *sh_eth_get_stats(struct net_device *ndev) if (mdp->cd->no_tx_cntrs) return &ndev->stats; - if (!mdp->is_opened) + if (!netif_running(ndev)) return &ndev->stats; sh_eth_update_stat(ndev, &ndev->stats.tx_dropped, TROCR); @@ -2614,8 +2612,6 @@ static int sh_eth_close(struct net_device *ndev) /* Free all the skbuffs in the Rx queue and the DMA buffer. */ sh_eth_ring_free(ndev); - mdp->is_opened = 0; - pm_runtime_put(&mdp->pdev->dev); return 0; diff --git a/drivers/net/ethernet/renesas/sh_eth.h b/drivers/net/ethernet/renesas/sh_eth.h index a5c07c6ff44a..f56dbc8a064a 100644 --- a/drivers/net/ethernet/renesas/sh_eth.h +++ b/drivers/net/ethernet/renesas/sh_eth.h @@ -560,7 +560,6 @@ struct sh_eth_private { unsigned no_ether_link:1; unsigned ether_link_active_low:1; - unsigned is_opened:1; unsigned wol_enabled:1; }; |