diff options
| author | Dan Carpenter <dan.carpenter@linaro.org> | 2024-06-06 17:23:44 +0300 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2024-06-09 17:35:21 +0100 |
| commit | 28f961f9d5b7c3d9b9f93cc59e54477ba1278cf9 (patch) | |
| tree | f75df44f030b5ab18e0a7139aadf2b4fc47d2be0 /drivers/net/ethernet/ti/icssg/icssg_common.c | |
| parent | 924ee531754827bf23eacf35e6408a7f44fb9021 (diff) | |
| download | linux-stable-28f961f9d5b7c3d9b9f93cc59e54477ba1278cf9.tar.gz linux-stable-28f961f9d5b7c3d9b9f93cc59e54477ba1278cf9.tar.bz2 linux-stable-28f961f9d5b7c3d9b9f93cc59e54477ba1278cf9.zip | |
dmaengine: ti: k3-udma-glue: clean up return in k3_udma_glue_rx_get_irq()
Currently the k3_udma_glue_rx_get_irq() function returns either negative
error codes or zero on error. Generally, in the kernel, zero means
success so this be confusing and has caused bugs in the past. Also the
"tx" version of this function only returns negative error codes. Let's
clean this "rx" function so both functions match.
This patch has no effect on runtime.
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Acked-by: Peter Ujfalusi <peter.ujfalusi@gmail.com>
Acked-by: Vinod Koul <vkoul@kernel.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/ti/icssg/icssg_common.c')
| -rw-r--r-- | drivers/net/ethernet/ti/icssg/icssg_common.c | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/drivers/net/ethernet/ti/icssg/icssg_common.c b/drivers/net/ethernet/ti/icssg/icssg_common.c index 873126dfc173..2f716c0d7060 100644 --- a/drivers/net/ethernet/ti/icssg/icssg_common.c +++ b/drivers/net/ethernet/ti/icssg/icssg_common.c @@ -440,9 +440,7 @@ int prueth_init_rx_chns(struct prueth_emac *emac, fdqring_id = k3_udma_glue_rx_flow_get_fdq_id(rx_chn->rx_chn, i); ret = k3_udma_glue_rx_get_irq(rx_chn->rx_chn, i); - if (ret <= 0) { - if (!ret) - ret = -ENXIO; + if (ret < 0) { netdev_err(ndev, "Failed to get rx dma irq"); goto fail; } |