diff options
| author | Markus Elfring <elfring@users.sourceforge.net> | 2014-11-20 16:42:51 +0100 |
|---|---|---|
| committer | John W. Linville <linville@tuxdriver.com> | 2014-11-20 16:14:39 -0500 |
| commit | ac96ce83ff21c9338afa0e81baabd902d9350015 (patch) | |
| tree | 3d1dfd055a60893235c2611be8be8aa0e620dca9 /drivers/net/wireless/brcm80211/brcmfmac/msgbuf.c | |
| parent | 9a638ddfb09e5aa17158842c95526e1aa79f92e6 (diff) | |
| download | linux-stable-ac96ce83ff21c9338afa0e81baabd902d9350015.tar.gz linux-stable-ac96ce83ff21c9338afa0e81baabd902d9350015.tar.bz2 linux-stable-ac96ce83ff21c9338afa0e81baabd902d9350015.zip | |
net: brcm80211: Deletion of unnecessary checks before two function calls
The functions brcmu_pkt_buf_free_skb() and release_firmware() test whether
their argument is NULL and then return immediately. Thus the test around
the call is not needed.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Acked-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
Diffstat (limited to 'drivers/net/wireless/brcm80211/brcmfmac/msgbuf.c')
| -rw-r--r-- | drivers/net/wireless/brcm80211/brcmfmac/msgbuf.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/net/wireless/brcm80211/brcmfmac/msgbuf.c b/drivers/net/wireless/brcm80211/brcmfmac/msgbuf.c index 02d39ce8dbca..9f783db34ae5 100644 --- a/drivers/net/wireless/brcm80211/brcmfmac/msgbuf.c +++ b/drivers/net/wireless/brcm80211/brcmfmac/msgbuf.c @@ -518,8 +518,7 @@ static int brcmf_msgbuf_query_dcmd(struct brcmf_pub *drvr, int ifidx, memcpy(buf, skb->data, (len < msgbuf->ioctl_resp_ret_len) ? len : msgbuf->ioctl_resp_ret_len); } - if (skb) - brcmu_pkt_buf_free_skb(skb); + brcmu_pkt_buf_free_skb(skb); return msgbuf->ioctl_resp_status; } |