diff options
author | Anant Thazhemadam <anant.thazhemadam@gmail.com> | 2020-10-05 02:25:36 +0530 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2020-10-04 14:47:22 -0700 |
commit | 9a9e77495958c7382b2438bc19746dd3aaaabb8e (patch) | |
tree | 0fecd22ecdabd0463f8ea05327df537b7dc6fc35 /drivers/net | |
parent | 790ca79d3e7f76d77291540e1728f400c6ad931f (diff) | |
download | linux-stable-9a9e77495958c7382b2438bc19746dd3aaaabb8e.tar.gz linux-stable-9a9e77495958c7382b2438bc19746dd3aaaabb8e.tar.bz2 linux-stable-9a9e77495958c7382b2438bc19746dd3aaaabb8e.zip |
net: team: fix memory leak in __team_options_register
The variable "i" isn't initialized back correctly after the first loop
under the label inst_rollback gets executed.
The value of "i" is assigned to be option_count - 1, and the ensuing
loop (under alloc_rollback) begins by initializing i--.
Thus, the value of i when the loop begins execution will now become
i = option_count - 2.
Thus, when kfree(dst_opts[i]) is called in the second loop in this
order, (i.e., inst_rollback followed by alloc_rollback),
dst_optsp[option_count - 2] is the first element freed, and
dst_opts[option_count - 1] does not get freed, and thus, a memory
leak is caused.
This memory leak can be fixed, by assigning i = option_count (instead of
option_count - 1).
Fixes: 80f7c6683fe0 ("team: add support for per-port options")
Reported-by: syzbot+69b804437cfec30deac3@syzkaller.appspotmail.com
Tested-by: syzbot+69b804437cfec30deac3@syzkaller.appspotmail.com
Signed-off-by: Anant Thazhemadam <anant.thazhemadam@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net')
-rw-r--r-- | drivers/net/team/team.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/team/team.c b/drivers/net/team/team.c index 69dfb1a49cc8..bcc4a4c011f1 100644 --- a/drivers/net/team/team.c +++ b/drivers/net/team/team.c @@ -287,7 +287,7 @@ inst_rollback: for (i--; i >= 0; i--) __team_option_inst_del_option(team, dst_opts[i]); - i = option_count - 1; + i = option_count; alloc_rollback: for (i--; i >= 0; i--) kfree(dst_opts[i]); |