summaryrefslogtreecommitdiffstats
path: root/drivers/net
diff options
context:
space:
mode:
authorYang Yingliang <yangyingliang@huawei.com>2022-12-08 22:21:45 +0800
committerDavid S. Miller <davem@davemloft.net>2022-12-12 09:56:17 +0000
commitf07fadcbee2a5e84caa67c7c445424200bffb60b (patch)
treef25cda6f2c0fc061086ba05a71bf642363b209ed /drivers/net
parentd1678bf45f21fa5ae4a456f821858679556ea5f8 (diff)
downloadlinux-stable-f07fadcbee2a5e84caa67c7c445424200bffb60b.tar.gz
linux-stable-f07fadcbee2a5e84caa67c7c445424200bffb60b.tar.bz2
linux-stable-f07fadcbee2a5e84caa67c7c445424200bffb60b.zip
net: ethernet: dnet: don't call dev_kfree_skb() under spin_lock_irqsave()
It is not allowed to call kfree_skb() or consume_skb() from hardware interrupt context or with hardware interrupts being disabled. In this case, the lock is used to protected 'bp', so we can move dev_kfree_skb() after the spin_unlock_irqrestore(). Fixes: 4796417417a6 ("dnet: Dave DNET ethernet controller driver (updated)") Signed-off-by: Yang Yingliang <yangyingliang@huawei.com> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net')
-rw-r--r--drivers/net/ethernet/dnet.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/net/ethernet/dnet.c b/drivers/net/ethernet/dnet.c
index 08184f20f510..151ca9573be9 100644
--- a/drivers/net/ethernet/dnet.c
+++ b/drivers/net/ethernet/dnet.c
@@ -550,11 +550,11 @@ static netdev_tx_t dnet_start_xmit(struct sk_buff *skb, struct net_device *dev)
skb_tx_timestamp(skb);
+ spin_unlock_irqrestore(&bp->lock, flags);
+
/* free the buffer */
dev_kfree_skb(skb);
- spin_unlock_irqrestore(&bp->lock, flags);
-
return NETDEV_TX_OK;
}