diff options
author | Aya Levin <ayal@nvidia.com> | 2021-11-09 15:44:58 +0200 |
---|---|---|
committer | Saeed Mahameed <saeedm@nvidia.com> | 2021-11-16 20:31:48 -0800 |
commit | f28a14c1dcb0dbdae719a05b71ed30ce31221e75 (patch) | |
tree | dabac0a4a669f9b33f9edeadb316de81fcfbde1b /drivers/net | |
parent | aef0f8c67d752ed68cc18582711ac6accf0ad9b6 (diff) | |
download | linux-stable-f28a14c1dcb0dbdae719a05b71ed30ce31221e75.tar.gz linux-stable-f28a14c1dcb0dbdae719a05b71ed30ce31221e75.tar.bz2 linux-stable-f28a14c1dcb0dbdae719a05b71ed30ce31221e75.zip |
net/mlx5: Avoid printing health buffer when firmware is unavailable
Use firmware version field as an indication to health buffer's sanity.
When firmware version is 0xFFFFFFFF, deduce that firmware is unavailable
and avoid printing the health buffer to dmesg as it doesn't provide
debug info.
Signed-off-by: Aya Levin <ayal@nvidia.com>
Reviewed-by: Gal Pressman <gal@nvidia.com>
Signed-off-by: Saeed Mahameed <saeedm@nvidia.com>
Diffstat (limited to 'drivers/net')
-rw-r--r-- | drivers/net/ethernet/mellanox/mlx5/core/health.c | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/health.c b/drivers/net/ethernet/mellanox/mlx5/core/health.c index 64f1abc4dc36..75121bc1eaa5 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/health.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/health.c @@ -420,6 +420,11 @@ static void print_health_info(struct mlx5_core_dev *dev) if (!ioread8(&h->synd)) return; + if (ioread32be(&h->fw_ver) == 0xFFFFFFFF) { + mlx5_log(dev, LOGLEVEL_ERR, "PCI slot is unavailable\n"); + return; + } + rfr_severity = ioread8(&h->rfr_severity); severity = mlx5_health_get_severity(rfr_severity); mlx5_log(dev, severity, "Health issue observed, %s, severity(%d) %s:\n", |