diff options
author | Nathan Chancellor <nathan@kernel.org> | 2021-10-15 13:13:06 -0700 |
---|---|---|
committer | Dmitry Torokhov <dmitry.torokhov@gmail.com> | 2021-10-15 22:22:54 -0700 |
commit | a02dcde595f7cbd240ccd64de96034ad91cffc40 (patch) | |
tree | 24fdcd33767fb1d1c5da58ea711c28eafa7c0a2d /drivers/opp | |
parent | 3378a07daa6cdd11e042797454c706d1c69f9ca6 (diff) | |
download | linux-stable-a02dcde595f7cbd240ccd64de96034ad91cffc40.tar.gz linux-stable-a02dcde595f7cbd240ccd64de96034ad91cffc40.tar.bz2 linux-stable-a02dcde595f7cbd240ccd64de96034ad91cffc40.zip |
Input: touchscreen - avoid bitwise vs logical OR warning
A new warning in clang points out a few places in this driver where a
bitwise OR is being used with boolean types:
drivers/input/touchscreen.c:81:17: warning: use of bitwise '|' with boolean operands [-Wbitwise-instead-of-logical]
data_present = touchscreen_get_prop_u32(dev, "touchscreen-min-x",
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
This use of a bitwise OR is intentional, as bitwise operations do not
short circuit, which allows all the calls to touchscreen_get_prop_u32()
to happen so that the last parameter is initialized while coalescing the
results of the calls to make a decision after they are all evaluated.
To make this clearer to the compiler, use the '|=' operator to assign
the result of each touchscreen_get_prop_u32() call to data_present,
which keeps the meaning of the code the same but makes it obvious that
every one of these calls is expected to happen.
Signed-off-by: Nathan Chancellor <nathan@kernel.org>
Reported-by: Nick Desaulniers <ndesaulniers@google.com>
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
Link: https://lore.kernel.org/r/20211014205757.3474635-1-nathan@kernel.org
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Diffstat (limited to 'drivers/opp')
0 files changed, 0 insertions, 0 deletions