diff options
| author | Nishka Dasgupta <nishkadg.linux@gmail.com> | 2019-08-08 13:24:56 +0530 |
|---|---|---|
| committer | Linus Walleij <linus.walleij@linaro.org> | 2019-08-10 10:21:51 +0200 |
| commit | 474137c9111a533aeaa46c1630bb9fb106a46e30 (patch) | |
| tree | bb00328c14eecf319e243fd78fc0d5ace5fffe6e /drivers/pinctrl/stm32 | |
| parent | 21b2920fb587e570b43973300a11b921c3a61d3e (diff) | |
| download | linux-stable-474137c9111a533aeaa46c1630bb9fb106a46e30.tar.gz linux-stable-474137c9111a533aeaa46c1630bb9fb106a46e30.tar.bz2 linux-stable-474137c9111a533aeaa46c1630bb9fb106a46e30.zip | |
pinctrl: stm32: stm32: Add of_node_put() before return
Each iteration of for_each_child_of_node and
for_each_available_child_of_node puts the previous node, but in
the case of a return from the middle of the loop, there is no put, thus
causing a memory leak. Hence add an of_node_put before the return in
two places.
Issue found with Coccinelle.
Signed-off-by: Nishka Dasgupta <nishkadg.linux@gmail.com>
Link: https://lore.kernel.org/r/20190808075457.16109-1-nishkadg.linux@gmail.com
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Diffstat (limited to 'drivers/pinctrl/stm32')
| -rw-r--r-- | drivers/pinctrl/stm32/pinctrl-stm32.c | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/drivers/pinctrl/stm32/pinctrl-stm32.c b/drivers/pinctrl/stm32/pinctrl-stm32.c index b453aed1bbeb..2d5e0435af0a 100644 --- a/drivers/pinctrl/stm32/pinctrl-stm32.c +++ b/drivers/pinctrl/stm32/pinctrl-stm32.c @@ -615,6 +615,7 @@ static int stm32_pctrl_dt_node_to_map(struct pinctrl_dev *pctldev, &reserved_maps, num_maps); if (ret < 0) { pinctrl_utils_free_map(pctldev, *map, *num_maps); + of_node_put(np); return ret; } } @@ -1468,8 +1469,10 @@ int stm32_pctl_probe(struct platform_device *pdev) for_each_available_child_of_node(np, child) { if (of_property_read_bool(child, "gpio-controller")) { ret = stm32_gpiolib_register_bank(pctl, child); - if (ret) + if (ret) { + of_node_put(child); return ret; + } pctl->nbanks++; } |