summaryrefslogtreecommitdiffstats
path: root/drivers/platform/chrome/cros_ec_lpc_mec.c
diff options
context:
space:
mode:
authorEnric Balletbo i Serra <enric.balletbo@collabora.com>2019-06-14 23:43:01 +0200
committerEnric Balletbo i Serra <enric.balletbo@collabora.com>2019-06-20 12:00:32 +0200
commit22c040fa21b604b9b3d88645e108fb2f0a74474b (patch)
treef03e0f4c4be98c4f1ad2f8c680ec2af9c813c9de /drivers/platform/chrome/cros_ec_lpc_mec.c
parent4116fd25c5262e90427f9840e861a8553374a867 (diff)
downloadlinux-stable-22c040fa21b604b9b3d88645e108fb2f0a74474b.tar.gz
linux-stable-22c040fa21b604b9b3d88645e108fb2f0a74474b.tar.bz2
linux-stable-22c040fa21b604b9b3d88645e108fb2f0a74474b.zip
platform/chrome: cros_ec_lpc: Choose Microchip EC at runtime
On many boards, communication between the kernel and the Embedded Controller happens over an LPC bus. In these cases, the kernel config CONFIG_CROS_EC_LPC is enabled. Some of these LPC boards contain a Microchip Embedded Controller (MEC) that is different from the regular EC. On these devices, the same LPC bus is used, but the protocol is a little different. In these cases, the CONFIG_CROS_EC_LPC_MEC kernel config is enabled. Currently, the kernel decides at compile-time whether or not to use the MEC variant, and, when that kernel option is selected it breaks the other boards. We would like a kind of runtime detection to avoid this. This patch adds that detection mechanism by probing the protocol at runtime, first we assume that a MEC variant is connected, and if the protocol fails it fallbacks to the regular EC. This adds a bit of overload because we try to read twice on those LPC boards that doesn't contain a MEC variant, but is a better solution than having to select the EC variant at compile-time. While here also fix the alignment in Kconfig file for this config option replacing the spaces by tabs. Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com> Reviewed-by: Ezequiel Garcia <ezequiel@collabora.com> Tested-by: Nick Crews <ncrews@chromium.org> Reviewed-by: Nick Crews <ncrews@chromium.org>
Diffstat (limited to 'drivers/platform/chrome/cros_ec_lpc_mec.c')
0 files changed, 0 insertions, 0 deletions