diff options
| author | YueHaibing <yuehaibing@huawei.com> | 2018-11-26 18:24:22 +0800 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2018-11-27 10:05:36 +0100 |
| commit | 3b1ad360acad6052c2568f891bb3d0f3f057016f (patch) | |
| tree | de4291619d8337d97483536676c2938931948c97 /drivers/pps/clients/pps-gpio.c | |
| parent | eb30abeedee76c04bdf41c6d88545472c11a5632 (diff) | |
| download | linux-stable-3b1ad360acad6052c2568f891bb3d0f3f057016f.tar.gz linux-stable-3b1ad360acad6052c2568f891bb3d0f3f057016f.tar.bz2 linux-stable-3b1ad360acad6052c2568f891bb3d0f3f057016f.zip | |
pps: using ERR_PTR instead of NULL while pps_register_source fails
pps_register_source() has keeps error codes in a local variable,
but it does not make use of the code. This patch let it return
the errcode in case of failure.
Suggested-by: Richard Cochran <richardcochran@gmail.com>
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Acked-by: Rodolfo Giometti <giometti@enneenne.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/pps/clients/pps-gpio.c')
| -rw-r--r-- | drivers/pps/clients/pps-gpio.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/pps/clients/pps-gpio.c b/drivers/pps/clients/pps-gpio.c index 333ad7d5b45b..dd5d1103e02b 100644 --- a/drivers/pps/clients/pps-gpio.c +++ b/drivers/pps/clients/pps-gpio.c @@ -158,10 +158,10 @@ static int pps_gpio_probe(struct platform_device *pdev) if (data->capture_clear) pps_default_params |= PPS_CAPTURECLEAR | PPS_OFFSETCLEAR; data->pps = pps_register_source(&data->info, pps_default_params); - if (data->pps == NULL) { + if (IS_ERR(data->pps)) { dev_err(&pdev->dev, "failed to register IRQ %d as PPS source\n", data->irq); - return -EINVAL; + return PTR_ERR(data->pps); } /* register IRQ interrupt handler */ |