diff options
author | Rhett Aultman <rhett.aultman@samsara.com> | 2022-07-03 19:33:06 +0200 |
---|---|---|
committer | Marc Kleine-Budde <mkl@pengutronix.de> | 2022-07-04 11:42:59 +0200 |
commit | 2bda24ef95c0311ab93bda00db40486acf30bd0a (patch) | |
tree | 595725185a0462104041144e75394b9c183bb1cd /drivers/rapidio/rio_cm.c | |
parent | 374e11f1bde91545674233459e5a0416ba842b69 (diff) | |
download | linux-stable-2bda24ef95c0311ab93bda00db40486acf30bd0a.tar.gz linux-stable-2bda24ef95c0311ab93bda00db40486acf30bd0a.tar.bz2 linux-stable-2bda24ef95c0311ab93bda00db40486acf30bd0a.zip |
can: gs_usb: gs_usb_open/close(): fix memory leak
The gs_usb driver appears to suffer from a malady common to many USB
CAN adapter drivers in that it performs usb_alloc_coherent() to
allocate a number of USB request blocks (URBs) for RX, and then later
relies on usb_kill_anchored_urbs() to free them, but this doesn't
actually free them. As a result, this may be leaking DMA memory that's
been used by the driver.
This commit is an adaptation of the techniques found in the esd_usb2
driver where a similar design pattern led to a memory leak. It
explicitly frees the RX URBs and their DMA memory via a call to
usb_free_coherent(). Since the RX URBs were allocated in the
gs_can_open(), we remove them in gs_can_close() rather than in the
disconnect function as was done in esd_usb2.
For more information, see the 928150fad41b ("can: esd_usb2: fix memory
leak").
Link: https://lore.kernel.org/all/alpine.DEB.2.22.394.2206031547001.1630869@thelappy
Fixes: d08e973a77d1 ("can: gs_usb: Added support for the GS_USB CAN devices")
Cc: stable@vger.kernel.org
Signed-off-by: Rhett Aultman <rhett.aultman@samsara.com>
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
Diffstat (limited to 'drivers/rapidio/rio_cm.c')
0 files changed, 0 insertions, 0 deletions