diff options
author | Gustavo A. R. Silva <gustavo@embeddedor.com> | 2018-08-23 13:51:40 -0500 |
---|---|---|
committer | Alexandre Belloni <alexandre.belloni@bootlin.com> | 2018-08-27 23:02:18 +0200 |
commit | 725e0e15f84bb30e83fad8fa4b4dd1f335506172 (patch) | |
tree | f4242387a71957aded2e03b88eca2f9fb71a0e5c /drivers/rtc | |
parent | 1e6e4e169a8aef8127ff9ffece6290fafe0d92bf (diff) | |
download | linux-stable-725e0e15f84bb30e83fad8fa4b4dd1f335506172.tar.gz linux-stable-725e0e15f84bb30e83fad8fa4b4dd1f335506172.tar.bz2 linux-stable-725e0e15f84bb30e83fad8fa4b4dd1f335506172.zip |
rtc: sun6i: Use struct_size() in kzalloc()
One of the more common cases of allocation size calculations is finding
the size of a structure that has a zero-sized array at the end, along
with memory for some number of elements for that array. For example:
struct foo {
int stuff;
void *entry[];
};
instance = kzalloc(sizeof(struct foo) + sizeof(void *) * count, GFP_KERNEL);
Instead of leaving these open-coded and prone to type mistakes, we can
now use the new struct_size() helper:
instance = kzalloc(struct_size(instance, entry, count), GFP_KERNEL);
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Reviewed-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
Diffstat (limited to 'drivers/rtc')
-rw-r--r-- | drivers/rtc/rtc-sun6i.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/rtc/rtc-sun6i.c b/drivers/rtc/rtc-sun6i.c index 2cd5a7b1a2e3..fe07310952df 100644 --- a/drivers/rtc/rtc-sun6i.c +++ b/drivers/rtc/rtc-sun6i.c @@ -199,8 +199,7 @@ static void __init sun6i_rtc_clk_init(struct device_node *node) if (!rtc) return; - clk_data = kzalloc(sizeof(*clk_data) + (sizeof(*clk_data->hws) * 2), - GFP_KERNEL); + clk_data = kzalloc(struct_size(clk_data, hws, 2), GFP_KERNEL); if (!clk_data) { kfree(rtc); return; |