summaryrefslogtreecommitdiffstats
path: root/drivers/s390/crypto
diff options
context:
space:
mode:
authorHarald Freudenberger <freude@linux.ibm.com>2021-10-20 16:14:11 +0200
committerVasily Gorbik <gor@linux.ibm.com>2021-10-26 15:21:30 +0200
commit132c1e74aa7f8f9d33552645d2c35d3d8f9f0cf1 (patch)
tree1c13496d73afd6b749a1ab926de2a178097c77be /drivers/s390/crypto
parentad9a14517263a16af040598c7920c09ca9670a31 (diff)
downloadlinux-stable-132c1e74aa7f8f9d33552645d2c35d3d8f9f0cf1.tar.gz
linux-stable-132c1e74aa7f8f9d33552645d2c35d3d8f9f0cf1.tar.bz2
linux-stable-132c1e74aa7f8f9d33552645d2c35d3d8f9f0cf1.zip
s390/ap: function rework based on compiler warning
Slight rework of function __ap_revise_reserved() because of unused variable warning when build with W=1. This patch introduces an additional debug feature warning message when device_reprobe() returns with failure. However, the return value of __ap_revise_reserved() is still hard coded to 0 as this is a callback function to be used together with bus_for_each_dev() and thus the return value indicates to go on with the bus_for_each_dev() loop and not apport on a failure of something within this function. Signed-off-by: Harald Freudenberger <freude@linux.ibm.com> Signed-off-by: Vasily Gorbik <gor@linux.ibm.com>
Diffstat (limited to 'drivers/s390/crypto')
-rw-r--r--drivers/s390/crypto/ap_bus.c3
1 files changed, 3 insertions, 0 deletions
diff --git a/drivers/s390/crypto/ap_bus.c b/drivers/s390/crypto/ap_bus.c
index 806d184482a9..1986243f9cd3 100644
--- a/drivers/s390/crypto/ap_bus.c
+++ b/drivers/s390/crypto/ap_bus.c
@@ -793,6 +793,9 @@ static int __ap_revise_reserved(struct device *dev, void *dummy)
AP_DBF_DBG("%s reprobing queue=%02x.%04x\n",
__func__, card, queue);
rc = device_reprobe(dev);
+ if (rc)
+ AP_DBF_WARN("%s reprobing queue=%02x.%04x failed\n",
+ __func__, card, queue);
}
}