diff options
author | Ben Hutchings <ben@decadent.org.uk> | 2014-06-08 23:33:25 +0100 |
---|---|---|
committer | Christoph Hellwig <hch@lst.de> | 2014-07-25 17:16:54 -0400 |
commit | 03a6c3ff3282ee9fa893089304d951e0be93a144 (patch) | |
tree | 26c7b0268508c66ee5715bf935fcaf803aeeb8a4 /drivers/scsi/bfa/bfad_bsg.c | |
parent | 7626d9f36cdeab32bd12ea783aa8ee9fea0a41a2 (diff) | |
download | linux-stable-03a6c3ff3282ee9fa893089304d951e0be93a144.tar.gz linux-stable-03a6c3ff3282ee9fa893089304d951e0be93a144.tar.bz2 linux-stable-03a6c3ff3282ee9fa893089304d951e0be93a144.zip |
bfa: Fix undefined bit shift on big-endian architectures with 32-bit DMA address
bfa_swap_words() shifts its argument (assumed to be 64-bit) by 32 bits
each way. In two places the argument type is dma_addr_t, which may be
32-bit, in which case the effect of the bit shift is undefined:
drivers/scsi/bfa/bfa_fcpim.c: In function 'bfa_ioim_send_ioreq':
drivers/scsi/bfa/bfa_fcpim.c:2497:4: warning: left shift count >= width of type [enabled by default]
addr = bfa_sgaddr_le(sg_dma_address(sg));
^
drivers/scsi/bfa/bfa_fcpim.c:2497:4: warning: right shift count >= width of type [enabled by default]
drivers/scsi/bfa/bfa_fcpim.c:2509:4: warning: left shift count >= width of type [enabled by default]
addr = bfa_sgaddr_le(sg_dma_address(sg));
^
drivers/scsi/bfa/bfa_fcpim.c:2509:4: warning: right shift count >= width of type [enabled by default]
Avoid this by adding casts to u64 in bfa_swap_words().
Compile-tested only.
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>
Acked-by: Anil Gurumurthy <anil.gurumurthy@qlogic.com>
Cc: stable@vger.kernel.org
Fixes: f16a17507b09 ('[SCSI] bfa: remove all OS wrappers')
Signed-off-by: Christoph Hellwig <hch@lst.de>
Diffstat (limited to 'drivers/scsi/bfa/bfad_bsg.c')
0 files changed, 0 insertions, 0 deletions