diff options
| author | Andy Shevchenko <andy.shevchenko@gmail.com> | 2015-11-26 20:22:50 +0200 |
|---|---|---|
| committer | Martin K. Petersen <martin.petersen@oracle.com> | 2015-11-30 12:12:19 -0500 |
| commit | fa785f0a984d863a24d2f288b68757188a50261b (patch) | |
| tree | f6ad2fb8a894e5a625a97e15b070db434f2b7ba6 /drivers/scsi/scsi_debug.c | |
| parent | 09e2b0b14690fb13ccfc04af49f156df3e25b152 (diff) | |
| download | linux-stable-fa785f0a984d863a24d2f288b68757188a50261b.tar.gz linux-stable-fa785f0a984d863a24d2f288b68757188a50261b.tar.bz2 linux-stable-fa785f0a984d863a24d2f288b68757188a50261b.zip | |
scsi_debug: check for bigger value first
Even for signed types we have to check for bigger positive value first.
Otherwise it will be never happened.
Signed-off-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Acked-by: Douglas Gilbert <dgilbert@interlog.com>
Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de>
Reviewed-by: Ewan Milne <emilne@redhat.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Diffstat (limited to 'drivers/scsi/scsi_debug.c')
| -rw-r--r-- | drivers/scsi/scsi_debug.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/drivers/scsi/scsi_debug.c b/drivers/scsi/scsi_debug.c index ec622ba9864a..1bea1adc16a8 100644 --- a/drivers/scsi/scsi_debug.c +++ b/drivers/scsi/scsi_debug.c @@ -4846,10 +4846,10 @@ static int __init scsi_debug_init(void) /* play around with geometry, don't waste too much on track 0 */ sdebug_heads = 8; sdebug_sectors_per = 32; - if (scsi_debug_dev_size_mb >= 16) - sdebug_heads = 32; - else if (scsi_debug_dev_size_mb >= 256) + if (scsi_debug_dev_size_mb >= 256) sdebug_heads = 64; + else if (scsi_debug_dev_size_mb >= 16) + sdebug_heads = 32; sdebug_cylinders_per = (unsigned long)sdebug_capacity / (sdebug_sectors_per * sdebug_heads); if (sdebug_cylinders_per >= 1024) { |