summaryrefslogtreecommitdiffstats
path: root/drivers/soc
diff options
context:
space:
mode:
authorSibi Sankar <sibis@codeaurora.org>2020-04-15 11:59:55 +0530
committerBjorn Andersson <bjorn.andersson@linaro.org>2020-04-20 23:57:58 -0700
commit02d8ecc18b8f392389ac9e7b785b0230ecb80833 (patch)
tree3bb40198580edae965bf0addd0638ec6b42e4969 /drivers/soc
parent35bb4b22f606c0cc8eedf567313adc18161b1af4 (diff)
downloadlinux-stable-02d8ecc18b8f392389ac9e7b785b0230ecb80833.tar.gz
linux-stable-02d8ecc18b8f392389ac9e7b785b0230ecb80833.tar.bz2
linux-stable-02d8ecc18b8f392389ac9e7b785b0230ecb80833.zip
soc: qcom: pdr: Remove impossible error condition
The patch fbe639b44a82: "soc: qcom: Introduce Protection Domain Restart helpers" leads to the following static checker warning: drivers/soc/qcom/pdr_interface.c:158 pdr_register_listener() '(resp.curr_state < (-((~0 >> 1)) - 1)) => (s32min-s32max < s32min)' These are casted to int so they can't be outside of int range. Fixes: fbe639b44a82 ("soc: qcom: Introduce Protection Domain Restart helpers") Reported-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Sibi Sankar <sibis@codeaurora.org> Link: https://lore.kernel.org/r/20200415062955.21439-1-sibis@codeaurora.org Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Diffstat (limited to 'drivers/soc')
-rw-r--r--drivers/soc/qcom/pdr_interface.c4
1 files changed, 0 insertions, 4 deletions
diff --git a/drivers/soc/qcom/pdr_interface.c b/drivers/soc/qcom/pdr_interface.c
index 17ad3b8698e1..bdcf16f88a97 100644
--- a/drivers/soc/qcom/pdr_interface.c
+++ b/drivers/soc/qcom/pdr_interface.c
@@ -155,10 +155,6 @@ static int pdr_register_listener(struct pdr_handle *pdr,
return ret;
}
- if ((int)resp.curr_state < INT_MIN || (int)resp.curr_state > INT_MAX)
- pr_err("PDR: %s notification state invalid: 0x%x\n",
- pds->service_path, resp.curr_state);
-
pds->state = resp.curr_state;
return 0;