diff options
| author | Lukas Wunner <lukas@wunner.de> | 2020-05-15 17:58:01 +0200 |
|---|---|---|
| committer | Mark Brown <broonie@kernel.org> | 2020-05-20 15:16:10 +0100 |
| commit | 84855678add8aba927faf76bc2f130a40f94b6f7 (patch) | |
| tree | 3dc0802c76bace05d5e969f61fc3dede0d580fe5 /drivers/spi/spi-bcm2835.c | |
| parent | 0392727c261bab65a35cd4f82ee9459bc237591d (diff) | |
| download | linux-stable-84855678add8aba927faf76bc2f130a40f94b6f7.tar.gz linux-stable-84855678add8aba927faf76bc2f130a40f94b6f7.tar.bz2 linux-stable-84855678add8aba927faf76bc2f130a40f94b6f7.zip | |
spi: Fix controller unregister order
When an SPI controller unregisters, it unbinds all its slave devices.
For this, their drivers may need to access the SPI bus, e.g. to quiesce
interrupts.
However since commit ffbbdd21329f ("spi: create a message queueing
infrastructure"), spi_destroy_queue() is executed before unbinding the
slaves. It sets ctlr->running = false, thereby preventing SPI bus
access and causing unbinding of slave devices to fail.
Fix by unbinding slaves before calling spi_destroy_queue().
Fixes: ffbbdd21329f ("spi: create a message queueing infrastructure")
Signed-off-by: Lukas Wunner <lukas@wunner.de>
Cc: stable@vger.kernel.org # v3.4+
Cc: Linus Walleij <linus.walleij@linaro.org>
Link: https://lore.kernel.org/r/8aaf9d44c153fe233b17bc2dec4eb679898d7e7b.1589557526.git.lukas@wunner.de
Signed-off-by: Mark Brown <broonie@kernel.org>
Diffstat (limited to 'drivers/spi/spi-bcm2835.c')
0 files changed, 0 insertions, 0 deletions