diff options
author | Barry Song <song.bao.hua@hisilicon.com> | 2020-09-26 12:16:15 +1200 |
---|---|---|
committer | Mark Brown <broonie@kernel.org> | 2020-10-01 23:45:27 +0100 |
commit | 69544f2c15926379d6fb182b142e044b7378b5cf (patch) | |
tree | 6416ad334d3878af0e66e8b1185966579f882b4a /drivers/spi/spi-tegra20-sflash.c | |
parent | 23f370c748580643d17b5e064478b89cba3fdc78 (diff) | |
download | linux-stable-69544f2c15926379d6fb182b142e044b7378b5cf.tar.gz linux-stable-69544f2c15926379d6fb182b142e044b7378b5cf.tar.bz2 linux-stable-69544f2c15926379d6fb182b142e044b7378b5cf.zip |
spi: spi-tegra20-sflash: remove redundant irqsave and irqrestore in hardIRQ
Running in hardIRQ, disabling IRQ is redundant.
Signed-off-by: Barry Song <song.bao.hua@hisilicon.com>
Link: https://lore.kernel.org/r/20200926001616.21292-1-song.bao.hua@hisilicon.com
Signed-off-by: Mark Brown <broonie@kernel.org>
Diffstat (limited to 'drivers/spi/spi-tegra20-sflash.c')
-rw-r--r-- | drivers/spi/spi-tegra20-sflash.c | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/drivers/spi/spi-tegra20-sflash.c b/drivers/spi/spi-tegra20-sflash.c index 02cf5f463ba6..b59015c7c8a8 100644 --- a/drivers/spi/spi-tegra20-sflash.c +++ b/drivers/spi/spi-tegra20-sflash.c @@ -359,9 +359,8 @@ exit: static irqreturn_t handle_cpu_based_xfer(struct tegra_sflash_data *tsd) { struct spi_transfer *t = tsd->curr_xfer; - unsigned long flags; - spin_lock_irqsave(&tsd->lock, flags); + spin_lock(&tsd->lock); if (tsd->tx_status || tsd->rx_status || (tsd->status_reg & SPI_BSY)) { dev_err(tsd->dev, "CpuXfer ERROR bit set 0x%x\n", tsd->status_reg); @@ -391,7 +390,7 @@ static irqreturn_t handle_cpu_based_xfer(struct tegra_sflash_data *tsd) tegra_sflash_calculate_curr_xfer_param(tsd->cur_spi, tsd, t); tegra_sflash_start_cpu_based_transfer(tsd, t); exit: - spin_unlock_irqrestore(&tsd->lock, flags); + spin_unlock(&tsd->lock); return IRQ_HANDLED; } |