diff options
| author | Christophe JAILLET <christophe.jaillet@wanadoo.fr> | 2023-02-15 14:01:28 +0100 |
|---|---|---|
| committer | Mark Brown <broonie@kernel.org> | 2023-02-15 16:07:53 +0000 |
| commit | e6a0b671880207566e1ece983bf989dde60bc1d7 (patch) | |
| tree | 393ff68a9bca2c5efe90cdb90b203f22c7c25565 /drivers/spi | |
| parent | 1dd46599f83ac5323a175d32955b1270e95cd11b (diff) | |
| download | linux-stable-e6a0b671880207566e1ece983bf989dde60bc1d7.tar.gz linux-stable-e6a0b671880207566e1ece983bf989dde60bc1d7.tar.bz2 linux-stable-e6a0b671880207566e1ece983bf989dde60bc1d7.zip | |
spi: synquacer: Fix timeout handling in synquacer_spi_transfer_one()
wait_for_completion_timeout() never returns a <0 value. It returns either
on timeout or a positive value (at least 1, or number of jiffies left
till timeout)
So, fix the error handling path and return -ETIMEDOUT should a timeout
occur.
Fixes: b0823ee35cf9 ("spi: Add spi driver for Socionext SynQuacer platform")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Acked-by: Jassi Brar <jaswinder.singh@linaro.org>
Link: https://lore.kernel.org/r/c2040bf3cfa201fd8890cfab14fa5a701ffeca14.1676466072.git.christophe.jaillet@wanadoo.fr
Signed-off-by: Mark Brown <broonie@kernel.org>
Diffstat (limited to 'drivers/spi')
| -rw-r--r-- | drivers/spi/spi-synquacer.c | 7 |
1 files changed, 3 insertions, 4 deletions
diff --git a/drivers/spi/spi-synquacer.c b/drivers/spi/spi-synquacer.c index 47cbe73137c2..dc188f9202c9 100644 --- a/drivers/spi/spi-synquacer.c +++ b/drivers/spi/spi-synquacer.c @@ -472,10 +472,9 @@ static int synquacer_spi_transfer_one(struct spi_master *master, read_fifo(sspi); } - if (status < 0) { - dev_err(sspi->dev, "failed to transfer. status: 0x%x\n", - status); - return status; + if (status == 0) { + dev_err(sspi->dev, "failed to transfer. Timeout.\n"); + return -ETIMEDOUT; } return 0; |