summaryrefslogtreecommitdiffstats
path: root/drivers/staging/greybus/connection.c
diff options
context:
space:
mode:
authorViresh Kumar <viresh.kumar@linaro.org>2015-08-13 10:40:28 +0530
committerGreg Kroah-Hartman <gregkh@google.com>2015-08-13 19:19:31 -0700
commit435ea76218c9f3257990c6da8b37bf7708598f49 (patch)
tree22207a16608012442635558fadfc070d2a4211fe /drivers/staging/greybus/connection.c
parent22322c474551c208625d3b95ffba39b1882fa645 (diff)
downloadlinux-stable-435ea76218c9f3257990c6da8b37bf7708598f49.tar.gz
linux-stable-435ea76218c9f3257990c6da8b37bf7708598f49.tar.bz2
linux-stable-435ea76218c9f3257990c6da8b37bf7708598f49.zip
greybus: connection: Don't free resources freed by gb_connection_release()
We are already doing put_device() here and so don't need to free resources directly, except ida. Fixes: afde17fe0b61 ("greybus/connection: fix jump label on device_add failure") Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org> Signed-off-by: Greg Kroah-Hartman <gregkh@google.com>
Diffstat (limited to 'drivers/staging/greybus/connection.c')
-rw-r--r--drivers/staging/greybus/connection.c4
1 files changed, 1 insertions, 3 deletions
diff --git a/drivers/staging/greybus/connection.c b/drivers/staging/greybus/connection.c
index d0f499d509ba..7eb28680e498 100644
--- a/drivers/staging/greybus/connection.c
+++ b/drivers/staging/greybus/connection.c
@@ -270,7 +270,7 @@ gb_connection_create_range(struct greybus_host_device *hd,
pr_err("failed to add connection device for cport 0x%04hx\n",
cport_id);
- goto err_free_kfifo;
+ goto err_remove_ida;
}
spin_lock_irq(&gb_connections_lock);
@@ -296,8 +296,6 @@ gb_connection_create_range(struct greybus_host_device *hd,
return connection;
-err_free_kfifo:
- kfifo_free(&connection->ts_kfifo);
err_destroy_wq:
destroy_workqueue(connection->wq);
err_free_connection: