summaryrefslogtreecommitdiffstats
path: root/drivers/staging/greybus/connection.c
diff options
context:
space:
mode:
authorBryan O'Donoghue <bryan.odonoghue@linaro.org>2015-08-11 13:50:50 +0100
committerGreg Kroah-Hartman <gregkh@google.com>2015-08-11 20:00:40 -0700
commit8ebc998f5fb146b7304fb7ac4e4d80059b6197fe (patch)
treef18d47558870994353b35819b365a33fd8cdc411 /drivers/staging/greybus/connection.c
parentbf81454738990e7acd089e1b8aac8bab6a54637f (diff)
downloadlinux-stable-8ebc998f5fb146b7304fb7ac4e4d80059b6197fe.tar.gz
linux-stable-8ebc998f5fb146b7304fb7ac4e4d80059b6197fe.tar.bz2
linux-stable-8ebc998f5fb146b7304fb7ac4e4d80059b6197fe.zip
greybus: connection: fix jump label on device_add failure
On device_add() failure in gb_connection_create_range() we jump to err_remove_ida. Instead we should be jumping to err_free_connection, so change the flow to accomodate. Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org> Signed-off-by: Greg Kroah-Hartman <gregkh@google.com>
Diffstat (limited to 'drivers/staging/greybus/connection.c')
-rw-r--r--drivers/staging/greybus/connection.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/staging/greybus/connection.c b/drivers/staging/greybus/connection.c
index 88383b6e603f..3765aa87ef2d 100644
--- a/drivers/staging/greybus/connection.c
+++ b/drivers/staging/greybus/connection.c
@@ -238,7 +238,7 @@ gb_connection_create_range(struct greybus_host_device *hd,
pr_err("failed to add connection device for cport 0x%04hx\n",
cport_id);
- goto err_remove_ida;
+ goto err_free_connection;
}
spin_lock_irq(&gb_connections_lock);