diff options
author | Jean-Michel Hautbois <jeanmichel.hautbois@ideasonboard.com> | 2022-06-17 10:45:19 +0200 |
---|---|---|
committer | Mauro Carvalho Chehab <mchehab@kernel.org> | 2022-09-24 09:01:59 +0200 |
commit | 4b7444ff13250d2b10e940978bd72aef7a5561f2 (patch) | |
tree | 8b6c6401bec822c7b24b5977c0724f1daaecaea6 /drivers/staging/media/ipu3 | |
parent | 39434d42e87fe23bff9f39d7b7485ad7764297d1 (diff) | |
download | linux-stable-4b7444ff13250d2b10e940978bd72aef7a5561f2.tar.gz linux-stable-4b7444ff13250d2b10e940978bd72aef7a5561f2.tar.bz2 linux-stable-4b7444ff13250d2b10e940978bd72aef7a5561f2.zip |
media: staging: ipu3-imgu: Fix BNR wb gain documentation
The documentation states that the BNR factor is a multiplier coded as
u3.13 and with a range of (0, 8). This is not correct, as the isp is
adding 1.0 to the gain applied, ie Pout = { Pin * (1 + Gx) }.
It means that a gain of 1.0 should be coded as 0.
Signed-off-by: Jean-Michel Hautbois <jeanmichel.hautbois@ideasonboard.com>
Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
Diffstat (limited to 'drivers/staging/media/ipu3')
-rw-r--r-- | drivers/staging/media/ipu3/include/uapi/intel-ipu3.h | 7 |
1 files changed, 5 insertions, 2 deletions
diff --git a/drivers/staging/media/ipu3/include/uapi/intel-ipu3.h b/drivers/staging/media/ipu3/include/uapi/intel-ipu3.h index dbdd015ce220..caa358e0bae4 100644 --- a/drivers/staging/media/ipu3/include/uapi/intel-ipu3.h +++ b/drivers/staging/media/ipu3/include/uapi/intel-ipu3.h @@ -626,8 +626,11 @@ struct ipu3_uapi_stats_3a { * @b: white balance gain for B channel. * @gb: white balance gain for Gb channel. * - * Precision u3.13, range [0, 8). White balance correction is done by applying - * a multiplicative gain to each color channels prior to BNR. + * For BNR parameters WB gain factor for the three channels [Ggr, Ggb, Gb, Gr]. + * Their precision is U3.13 and the range is (0, 8) and the actual gain is + * Gx + 1, it is typically Gx = 1. + * + * Pout = {Pin * (1 + Gx)}. */ struct ipu3_uapi_bnr_static_config_wb_gains_config { __u16 gr; |