diff options
| author | Uwe Kleine-König <u.kleine-koenig@pengutronix.de> | 2023-04-03 17:40:07 +0200 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2023-04-03 21:49:54 +0200 |
| commit | 51559b8e9bf9e3324413ab1c171df05d408dd81b (patch) | |
| tree | e94d39bb06798b10d97522835c2f39cdba7b2bb6 /drivers/staging/most | |
| parent | 7846a2ae5ccd1d08bcfff4a6cfedbc33680cf6cc (diff) | |
| download | linux-stable-51559b8e9bf9e3324413ab1c171df05d408dd81b.tar.gz linux-stable-51559b8e9bf9e3324413ab1c171df05d408dd81b.tar.bz2 linux-stable-51559b8e9bf9e3324413ab1c171df05d408dd81b.zip | |
staging: most: dim2: Convert to platform remove callback returning void
The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is (mostly) ignored
and this typically results in resource leaks. To improve here there is a
quest to make the remove callback return void. In the first step of this
quest all drivers are converted to .remove_new() which already returns
void.
Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Link: https://lore.kernel.org/r/20230403154014.2564054-18-u.kleine-koenig@pengutronix.de
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/staging/most')
| -rw-r--r-- | drivers/staging/most/dim2/dim2.c | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/drivers/staging/most/dim2/dim2.c b/drivers/staging/most/dim2/dim2.c index 9fa665c4038f..44d3252d4612 100644 --- a/drivers/staging/most/dim2/dim2.c +++ b/drivers/staging/most/dim2/dim2.c @@ -908,13 +908,11 @@ err_free_dev: * * Unregister the interface from mostcore */ -static int dim2_remove(struct platform_device *pdev) +static void dim2_remove(struct platform_device *pdev) { struct dim2_hdm *dev = platform_get_drvdata(pdev); most_deregister_interface(&dev->most_iface); - - return 0; } /* platform specific functions [[ */ @@ -1092,7 +1090,7 @@ MODULE_DEVICE_TABLE(of, dim2_of_match); static struct platform_driver dim2_driver = { .probe = dim2_probe, - .remove = dim2_remove, + .remove_new = dim2_remove, .driver = { .name = "hdm_dim2", .of_match_table = dim2_of_match, |