summaryrefslogtreecommitdiffstats
path: root/drivers/staging/most
diff options
context:
space:
mode:
authorMenna Mahmoud <eng.mennamahmoud.mm@gmail.com>2023-03-20 23:22:39 +0200
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2023-03-22 10:17:17 +0100
commitc388adce927c302dc740a550e79236f4dc9864b7 (patch)
tree9f00f8df6840c0f93c2fa1677866778f11295bda /drivers/staging/most
parent8f51a66a629b67a11250f555b89aa8d91137ed94 (diff)
downloadlinux-stable-c388adce927c302dc740a550e79236f4dc9864b7.tar.gz
linux-stable-c388adce927c302dc740a550e79236f4dc9864b7.tar.bz2
linux-stable-c388adce927c302dc740a550e79236f4dc9864b7.zip
staging: most: define iface_to_hdm as an inline function
Convert `iface_to_hdm` macro into a static inline function. it is not great to have macro that use `container_of` macro, because from looking at the definition one cannot tell what type it applies to. One can get the same benefit from an efficiency point of view by making an inline function. Suggested-by: Julia Lawall <julia.lawall@inria.fr> Signed-off-by: Menna Mahmoud <eng.mennamahmoud.mm@gmail.com> Link: https://lore.kernel.org/r/20230320212239.22452-1-eng.mennamahmoud.mm@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/staging/most')
-rw-r--r--drivers/staging/most/dim2/dim2.c5
1 files changed, 4 insertions, 1 deletions
diff --git a/drivers/staging/most/dim2/dim2.c b/drivers/staging/most/dim2/dim2.c
index b8bd01ca1f11..21d1c9f24c3d 100644
--- a/drivers/staging/most/dim2/dim2.c
+++ b/drivers/staging/most/dim2/dim2.c
@@ -108,7 +108,10 @@ struct dim2_platform_data {
u8 fcnt;
};
-#define iface_to_hdm(iface) container_of(iface, struct dim2_hdm, most_iface)
+static inline struct dim2_hdm *iface_to_hdm(struct most_interface *iface)
+{
+ return container_of(iface, struct dim2_hdm, most_iface);
+}
/* Macro to identify a network status message */
#define PACKET_IS_NET_INFO(p) \