summaryrefslogtreecommitdiffstats
path: root/drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c
diff options
context:
space:
mode:
authorBenoit Taine <benoit.taine@lip6.fr>2014-05-22 15:08:33 +0200
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2014-05-23 16:33:05 +0900
commit4a6eea4dcbc0328c3126fed264c42b0725bea659 (patch)
tree242ed4a18c9f920f4950d95969fdc98681a034b9 /drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c
parent48039e70b647424ee9cf529af7846effb270f417 (diff)
downloadlinux-stable-4a6eea4dcbc0328c3126fed264c42b0725bea659.tar.gz
linux-stable-4a6eea4dcbc0328c3126fed264c42b0725bea659.tar.bz2
linux-stable-4a6eea4dcbc0328c3126fed264c42b0725bea659.zip
staging: rtl8723au: Use kmemdup() instead of memcpy() to duplicate memory
This issue was reported by coccicheck using the semantic patch at scripts/coccinelle/api/memdup.cocci, and tested by compilation. Signed-off-by: Benoit Taine <benoit.taine@lip6.fr> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c')
-rw-r--r--drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c3
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c b/drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c
index a29fa76931c1..20c93e471adc 100644
--- a/drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c
+++ b/drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c
@@ -339,12 +339,11 @@ int rtl8723a_FirmwareDownload(struct rtw_adapter *padapter)
rtStatus = _FAIL;
goto Exit;
}
- firmware_buf = kzalloc(fw->size, GFP_KERNEL);
+ firmware_buf = kmemdup(fw->data, fw->size, GFP_KERNEL);
if (!firmware_buf) {
rtStatus = _FAIL;
goto Exit;
}
- memcpy(firmware_buf, fw->data, fw->size);
buf = firmware_buf;
fw_size = fw->size;
release_firmware(fw);