summaryrefslogtreecommitdiffstats
path: root/drivers/staging/sm750fb/ddk750_mode.c
diff options
context:
space:
mode:
authorDorcas AnonoLitunya <anonolitunya@gmail.com>2023-10-19 13:13:37 +0300
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2023-10-21 12:01:01 +0200
commit3cad0b9d0bdd3092f0b1b620e2375d8cc94c82f6 (patch)
tree20cabcedb39077083a1b3fdca0178b2318705cf9 /drivers/staging/sm750fb/ddk750_mode.c
parent45e173c0372a7bdd0eb543076e3b4c79fab38555 (diff)
downloadlinux-stable-3cad0b9d0bdd3092f0b1b620e2375d8cc94c82f6.tar.gz
linux-stable-3cad0b9d0bdd3092f0b1b620e2375d8cc94c82f6.tar.bz2
linux-stable-3cad0b9d0bdd3092f0b1b620e2375d8cc94c82f6.zip
staging: sm750fb: Remove unused return variable in program_mode_registers()
Drops variable ret as it is unused in the code. This therefore modifies the return type of program_mode_registers() to void from int since the return value is being ignored in all function calls. This improves code readability and maintainability. Suggested-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Signed-off-by: Dorcas AnonoLitunya <anonolitunya@gmail.com> Link: https://lore.kernel.org/r/20231019101348.22076-3-anonolitunya@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/staging/sm750fb/ddk750_mode.c')
-rw-r--r--drivers/staging/sm750fb/ddk750_mode.c8
1 files changed, 2 insertions, 6 deletions
diff --git a/drivers/staging/sm750fb/ddk750_mode.c b/drivers/staging/sm750fb/ddk750_mode.c
index f3f354831617..3b25892af713 100644
--- a/drivers/staging/sm750fb/ddk750_mode.c
+++ b/drivers/staging/sm750fb/ddk750_mode.c
@@ -75,10 +75,9 @@ display_control_adjust_SM750LE(struct mode_parameter *mode_param,
}
/* only timing related registers will be programed */
-static int program_mode_registers(struct mode_parameter *mode_param,
- struct pll_value *pll)
+static void program_mode_registers(struct mode_parameter *mode_param,
+ struct pll_value *pll)
{
- int ret = 0;
int cnt = 0;
unsigned int tmp, reg;
@@ -201,10 +200,7 @@ static int program_mode_registers(struct mode_parameter *mode_param,
break;
poke32(PANEL_DISPLAY_CTRL, tmp | reg);
}
- } else {
- ret = -1;
}
- return ret;
}
int ddk750_set_mode_timing(struct mode_parameter *parm, enum clock_type clock)