summaryrefslogtreecommitdiffstats
path: root/drivers/staging/usbip
diff options
context:
space:
mode:
authorJulia Lawall <julia@diku.dk>2011-08-22 16:00:33 +0200
committerGreg Kroah-Hartman <gregkh@suse.de>2011-08-23 14:42:34 -0700
commit93583548585048812dc05a728d182a13213a9fd2 (patch)
tree1075c7523c4d138dd990ce5b5710d381e201178b /drivers/staging/usbip
parent306dac699e02cb399f0c2546df8cb9f5bbee572c (diff)
downloadlinux-stable-93583548585048812dc05a728d182a13213a9fd2.tar.gz
linux-stable-93583548585048812dc05a728d182a13213a9fd2.tar.bz2
linux-stable-93583548585048812dc05a728d182a13213a9fd2.zip
drivers/staging/usbip/userspace/libsrc/vhci_driver.c: test the just-initialized value
Test the just-initialized value rather than some other one. The semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // <smpl> @r@ identifier x,y,f!={PTR_ERR,ERR_PTR,ERR_CAST}; statement S; @@ x = f(...); ( if (\(x == NULL\|IS_ERR(x)\)) S | *if (\(y == NULL\|IS_ERR(y)\)) { ... when != x return ...; } ) // </smpl> Signed-off-by: Julia Lawall <julia@diku.dk> Acked-by: David Chang <dchang@suse.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Diffstat (limited to 'drivers/staging/usbip')
-rw-r--r--drivers/staging/usbip/userspace/libsrc/vhci_driver.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/staging/usbip/userspace/libsrc/vhci_driver.c b/drivers/staging/usbip/userspace/libsrc/vhci_driver.c
index abbc285f4339..269787751b20 100644
--- a/drivers/staging/usbip/userspace/libsrc/vhci_driver.c
+++ b/drivers/staging/usbip/userspace/libsrc/vhci_driver.c
@@ -133,7 +133,7 @@ static int check_usbip_device(struct sysfs_class_device *cdev)
strlen(vhci_driver->hc_device->path))) {
/* found usbip device */
usbip_cdev = calloc(1, sizeof(*usbip_cdev));
- if (!cdev) {
+ if (!usbip_cdev) {
dbg("calloc failed");
return -1;
}