summaryrefslogtreecommitdiffstats
path: root/drivers/staging/vt6655
diff options
context:
space:
mode:
authorDan Carpenter <dan.carpenter@oracle.com>2011-09-23 09:23:22 +0300
committerGreg Kroah-Hartman <gregkh@suse.de>2011-09-26 17:43:44 -0700
commitde0920b1fedb4d694fe4732cfc3cccfcd4743f84 (patch)
tree599e30f3d96b9855c3474d033a144cd6e3576acb /drivers/staging/vt6655
parent43664e14a029ab458cba8af43c65853b079b282f (diff)
downloadlinux-stable-de0920b1fedb4d694fe4732cfc3cccfcd4743f84.tar.gz
linux-stable-de0920b1fedb4d694fe4732cfc3cccfcd4743f84.tar.bz2
linux-stable-de0920b1fedb4d694fe4732cfc3cccfcd4743f84.zip
Staging: vt6655-6: potential info leak in private_ioctl()
Smatch has a new check for Rosenberg type information leaks where structs are copied to the user with uninitialized stack data in them. In this path, the .uLinkRate member doesn't get initialized so I've set it to zero. Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Diffstat (limited to 'drivers/staging/vt6655')
-rw-r--r--drivers/staging/vt6655/ioctl.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/staging/vt6655/ioctl.c b/drivers/staging/vt6655/ioctl.c
index 8cf88c3b68da..43964a5e72a9 100644
--- a/drivers/staging/vt6655/ioctl.c
+++ b/drivers/staging/vt6655/ioctl.c
@@ -296,6 +296,7 @@ int private_ioctl(PSDevice pDevice, struct ifreq *rq) {
}
else {
sLinkStatus.bLink = false;
+ sLinkStatus.uLinkRate = 0;
}
if (copy_to_user(pReq->data, &sLinkStatus, sizeof(SCmdLinkStatus))) {
result = -EFAULT;