diff options
| author | Hans Verkuil <hverkuil@xs4all.nl> | 2019-02-20 03:59:00 -0500 |
|---|---|---|
| committer | Mauro Carvalho Chehab <mchehab+samsung@kernel.org> | 2019-03-19 13:39:00 -0400 |
| commit | 3bb7b493198353142c0acb4ed95cddd17a2c5d16 (patch) | |
| tree | 42a4c89581feb659d50b6a70fb2b3bc71804d87e /drivers/staging | |
| parent | ce3c2433b074eb9d569a0f63a15d6fd5dbc87f02 (diff) | |
| download | linux-stable-3bb7b493198353142c0acb4ed95cddd17a2c5d16.tar.gz linux-stable-3bb7b493198353142c0acb4ed95cddd17a2c5d16.tar.bz2 linux-stable-3bb7b493198353142c0acb4ed95cddd17a2c5d16.zip | |
media: imx7: fix smatch error
Fixes this smatch error:
drivers/staging/media/imx/imx7-mipi-csis.c:716 mipi_csis_set_fmt() error: we previously assumed 'fmt' could be null (see line 709)
fmt is never NULL, so remove the 'fmt &&' condition.
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Reviewed-by: Rui Miguel Silva <rmfrfs@gmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
Diffstat (limited to 'drivers/staging')
| -rw-r--r-- | drivers/staging/media/imx/imx7-mipi-csis.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/staging/media/imx/imx7-mipi-csis.c b/drivers/staging/media/imx/imx7-mipi-csis.c index 2ddcc42ab8ff..e1f2ef1fa76d 100644 --- a/drivers/staging/media/imx/imx7-mipi-csis.c +++ b/drivers/staging/media/imx/imx7-mipi-csis.c @@ -706,7 +706,7 @@ static int mipi_csis_set_fmt(struct v4l2_subdev *mipi_sd, fmt = mipi_csis_get_format(state, cfg, sdformat->which, sdformat->pad); mutex_lock(&state->lock); - if (fmt && sdformat->pad == CSIS_PAD_SOURCE) { + if (sdformat->pad == CSIS_PAD_SOURCE) { sdformat->format = *fmt; goto unlock; } |