diff options
| author | Ezequiel Garcia <ezequiel@collabora.com> | 2021-01-04 21:34:40 +0100 |
|---|---|---|
| committer | Mauro Carvalho Chehab <mchehab+huawei@kernel.org> | 2021-01-12 18:07:02 +0100 |
| commit | 89b14485caa4b7b2eaf70be0064f0978e68ebeee (patch) | |
| tree | 2aa2a80ba06629e428c8010340740f5a027a0e6d /drivers/staging | |
| parent | bb2216548a2b13cf2942a058b475438a7a6bb028 (diff) | |
| download | linux-stable-89b14485caa4b7b2eaf70be0064f0978e68ebeee.tar.gz linux-stable-89b14485caa4b7b2eaf70be0064f0978e68ebeee.tar.bz2 linux-stable-89b14485caa4b7b2eaf70be0064f0978e68ebeee.zip | |
media: imx: Fix csc/scaler unregister
The csc/scaler device private struct is released by
ipu_csc_scaler_video_device_release(), which can be called
by video_unregister_device() if there are no users
of the underlying struct video device.
Therefore, the mutex can't be held when calling
video_unregister_device() as its memory may be freed
by it, leading to a kernel oops.
Fortunately, the fix is quite simple as no locking
is needed when calling video_unregister_device(): v4l2-core
already has its own internal locking, and the structures
are also properly refcounted.
Fixes: a8ef0488cc59 ("media: imx: add csc/scaler mem2mem device")
Signed-off-by: Ezequiel Garcia <ezequiel@collabora.com>
Reviewed-by: Philipp Zabel <p.zabel@pengutronix.de>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Diffstat (limited to 'drivers/staging')
| -rw-r--r-- | drivers/staging/media/imx/imx-media-csc-scaler.c | 4 |
1 files changed, 0 insertions, 4 deletions
diff --git a/drivers/staging/media/imx/imx-media-csc-scaler.c b/drivers/staging/media/imx/imx-media-csc-scaler.c index fab1155a5958..63a0204502a8 100644 --- a/drivers/staging/media/imx/imx-media-csc-scaler.c +++ b/drivers/staging/media/imx/imx-media-csc-scaler.c @@ -869,11 +869,7 @@ void imx_media_csc_scaler_device_unregister(struct imx_media_video_dev *vdev) struct ipu_csc_scaler_priv *priv = vdev_to_priv(vdev); struct video_device *vfd = priv->vdev.vfd; - mutex_lock(&priv->mutex); - video_unregister_device(vfd); - - mutex_unlock(&priv->mutex); } struct imx_media_video_dev * |