summaryrefslogtreecommitdiffstats
path: root/drivers/staging
diff options
context:
space:
mode:
authorSalva Peiró <speirofr@gmail.com>2015-10-14 17:48:02 +0200
committerLuis Henriques <luis.henriques@canonical.com>2015-11-16 11:27:22 +0000
commitdf3a19b81c9449249f89babdca8a716a2f92d0ac (patch)
treec6b93566c47ea84c4c49987cd6d2e0f1388a7326 /drivers/staging
parent9bd814beb46d6d3d5eeb374c2b38c8b75523190a (diff)
downloadlinux-stable-df3a19b81c9449249f89babdca8a716a2f92d0ac.tar.gz
linux-stable-df3a19b81c9449249f89babdca8a716a2f92d0ac.tar.bz2
linux-stable-df3a19b81c9449249f89babdca8a716a2f92d0ac.zip
staging/dgnc: fix info leak in ioctl
commit 4b6184336ebb5c8dc1eae7f7ab46ee608a748b05 upstream. The dgnc_mgmt_ioctl() code fails to initialize the 16 _reserved bytes of struct digi_dinfo after the ->dinfo_nboards member. Add an explicit memset(0) before filling the structure to avoid the info leak. Signed-off-by: Salva Peiró <speirofr@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Cc: Moritz Mühlenhoff <jmm@inutil.org> Signed-off-by: Luis Henriques <luis.henriques@canonical.com>
Diffstat (limited to 'drivers/staging')
-rw-r--r--drivers/staging/dgnc/dgnc_mgmt.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/staging/dgnc/dgnc_mgmt.c b/drivers/staging/dgnc/dgnc_mgmt.c
index c5b425bf6692..eaba5d73362a 100644
--- a/drivers/staging/dgnc/dgnc_mgmt.c
+++ b/drivers/staging/dgnc/dgnc_mgmt.c
@@ -143,6 +143,7 @@ long dgnc_mgmt_ioctl(struct file *file, unsigned int cmd, unsigned long arg)
DGNC_LOCK(dgnc_global_lock, lock_flags);
+ memset(&ddi, 0, sizeof(ddi));
ddi.dinfo_nboards = dgnc_NumBoards;
sprintf(ddi.dinfo_version, "%s", DG_PART);