summaryrefslogtreecommitdiffstats
path: root/drivers/thunderbolt/nhi_ops.c
diff options
context:
space:
mode:
authorMika Westerberg <mika.westerberg@linux.intel.com>2020-11-18 13:08:21 +0200
committerMika Westerberg <mika.westerberg@linux.intel.com>2020-11-19 17:44:10 +0300
commit600c0849cf86b75d86352f59745226273290986a (patch)
treed375931563912b721f2a95def01371949421b36c /drivers/thunderbolt/nhi_ops.c
parent09162bc32c880a791c6c0668ce0745cf7958f576 (diff)
downloadlinux-stable-600c0849cf86b75d86352f59745226273290986a.tar.gz
linux-stable-600c0849cf86b75d86352f59745226273290986a.tar.bz2
linux-stable-600c0849cf86b75d86352f59745226273290986a.zip
thunderbolt: Fix use-after-free in remove_unplugged_switch()
Paulian reported a crash that happens when a dock is unplugged during hibernation: [78436.228217] thunderbolt 0-1: device disconnected [78436.228365] BUG: kernel NULL pointer dereference, address: 00000000000001e0 ... [78436.228397] RIP: 0010:icm_free_unplugged_children+0x109/0x1a0 ... [78436.228432] Call Trace: [78436.228439] icm_rescan_work+0x24/0x30 [78436.228444] process_one_work+0x1a3/0x3a0 [78436.228449] worker_thread+0x30/0x370 [78436.228454] ? process_one_work+0x3a0/0x3a0 [78436.228457] kthread+0x13d/0x160 [78436.228461] ? kthread_park+0x90/0x90 [78436.228465] ret_from_fork+0x1f/0x30 This happens because remove_unplugged_switch() calls tb_switch_remove() that releases the memory pointed by sw so the following lines reference to a memory that might be released already. Fix this by saving pointer to the parent device before calling tb_switch_remove(). Reported-by: Paulian Bogdan Marinca <paulian@marinca.net> Fixes: 4f7c2e0d8765 ("thunderbolt: Make sure device runtime resume completes before taking domain lock") Cc: stable@vger.kernel.org Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com> Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/thunderbolt/nhi_ops.c')
0 files changed, 0 insertions, 0 deletions