summaryrefslogtreecommitdiffstats
path: root/drivers/tty/hvc
diff options
context:
space:
mode:
authorUwe Kleine-König <u.kleine-koenig@pengutronix.de>2021-01-14 18:57:16 +0100
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2021-01-15 10:21:41 +0100
commitc24dc4bab20c88bd8f493e0339b8cc65df828acd (patch)
tree37718ad60385ec1f6c6b07d73b2a92f1dce0cf6d /drivers/tty/hvc
parent9335e23ddc33b5298b4cefdecc962736449fe596 (diff)
downloadlinux-stable-c24dc4bab20c88bd8f493e0339b8cc65df828acd.tar.gz
linux-stable-c24dc4bab20c88bd8f493e0339b8cc65df828acd.tar.bz2
linux-stable-c24dc4bab20c88bd8f493e0339b8cc65df828acd.zip
tty: hvcs: Drop unnecessary if block
If hvcs_probe() succeeded dev_set_drvdata() is called with a non-NULL value, and if hvcs_probe() failed hvcs_remove() isn't called. So there is no way dev_get_drvdata() can return NULL in hvcs_remove() and the check can just go away. Reviewed-by: Jiri Slaby <jirislaby@kernel.org> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Link: https://lore.kernel.org/r/20210114175718.137483-2-u.kleine-koenig@pengutronix.de Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/tty/hvc')
-rw-r--r--drivers/tty/hvc/hvcs.c3
1 files changed, 0 insertions, 3 deletions
diff --git a/drivers/tty/hvc/hvcs.c b/drivers/tty/hvc/hvcs.c
index dfe02283ed23..c90848919644 100644
--- a/drivers/tty/hvc/hvcs.c
+++ b/drivers/tty/hvc/hvcs.c
@@ -825,9 +825,6 @@ static int hvcs_remove(struct vio_dev *dev)
unsigned long flags;
struct tty_struct *tty;
- if (!hvcsd)
- return -ENODEV;
-
/* By this time the vty-server won't be getting any more interrupts */
spin_lock_irqsave(&hvcsd->lock, flags);