summaryrefslogtreecommitdiffstats
path: root/drivers/tty/serial/icom.c
diff options
context:
space:
mode:
authorHuang Guobin <huangguobin4@huawei.com>2022-03-31 17:10:05 +0800
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2022-04-15 08:42:40 +0200
commitee157a79e7c82b01ae4c25de0ac75899801f322c (patch)
treeedab443a71924d6f7851f389e50dbe86d59da6c9 /drivers/tty/serial/icom.c
parent570f749f4d54bd2db9b44c51aac3a6883f45a171 (diff)
downloadlinux-stable-ee157a79e7c82b01ae4c25de0ac75899801f322c.tar.gz
linux-stable-ee157a79e7c82b01ae4c25de0ac75899801f322c.tar.bz2
linux-stable-ee157a79e7c82b01ae4c25de0ac75899801f322c.zip
tty: Fix a possible resource leak in icom_probe
When pci_read_config_dword failed, call pci_release_regions() and pci_disable_device() to recycle the resource previously allocated. Reviewed-by: Jiri Slaby <jirislaby@kernel.org> Signed-off-by: Huang Guobin <huangguobin4@huawei.com> Link: https://lore.kernel.org/r/20220331091005.3290753-1-huangguobin4@huawei.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/tty/serial/icom.c')
-rw-r--r--drivers/tty/serial/icom.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/tty/serial/icom.c b/drivers/tty/serial/icom.c
index 03a2fe9f4c9a..02b375ba2f07 100644
--- a/drivers/tty/serial/icom.c
+++ b/drivers/tty/serial/icom.c
@@ -1501,7 +1501,7 @@ static int icom_probe(struct pci_dev *dev,
retval = pci_read_config_dword(dev, PCI_COMMAND, &command_reg);
if (retval) {
dev_err(&dev->dev, "PCI Config read FAILED\n");
- return retval;
+ goto probe_exit0;
}
pci_write_config_dword(dev, PCI_COMMAND,