diff options
| author | Wei Yongjun <weiyongjun1@huawei.com> | 2021-03-05 03:49:29 +0000 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2021-03-10 09:34:10 +0100 |
| commit | cebeddd6d0d9f839b9df2930b6a768b54913a763 (patch) | |
| tree | 6d98f375432b82173214a7a34a6cd8026e9697ef /drivers/tty/serial/liteuart.c | |
| parent | 81171e7d31a63e0e7f5c83701f097695e60a12db (diff) | |
| download | linux-stable-cebeddd6d0d9f839b9df2930b6a768b54913a763.tar.gz linux-stable-cebeddd6d0d9f839b9df2930b6a768b54913a763.tar.bz2 linux-stable-cebeddd6d0d9f839b9df2930b6a768b54913a763.zip | |
serial: liteuart: fix return value check in liteuart_probe()
In case of error, the function devm_platform_get_and_ioremap_resource()
returns ERR_PTR() and never returns NULL. The NULL test in the return
value check should be replaced with IS_ERR().
Fixes: 1da81e5562fa ("drivers/tty/serial: add LiteUART driver")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Link: https://lore.kernel.org/r/20210305034929.3234352-1-weiyongjun1@huawei.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/tty/serial/liteuart.c')
| -rw-r--r-- | drivers/tty/serial/liteuart.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/tty/serial/liteuart.c b/drivers/tty/serial/liteuart.c index 64842f3539e1..0b06770642cb 100644 --- a/drivers/tty/serial/liteuart.c +++ b/drivers/tty/serial/liteuart.c @@ -270,8 +270,8 @@ static int liteuart_probe(struct platform_device *pdev) /* get membase */ port->membase = devm_platform_get_and_ioremap_resource(pdev, 0, NULL); - if (!port->membase) - return -ENXIO; + if (IS_ERR(port->membase)) + return PTR_ERR(port->membase); /* values not from device tree */ port->dev = &pdev->dev; |