diff options
| author | Pavel Skripkin <paskripkin@gmail.com> | 2021-03-28 00:44:43 +0300 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2021-03-28 14:16:47 +0200 |
| commit | 211b4d42b70f1c1660feaa968dac0efc2a96ac4d (patch) | |
| tree | f423142ed134e76f183f5a3d18a3ade3dcf968ac /drivers/tty | |
| parent | 9f299d3264c67a892af87337dbaa0bdd20830c0c (diff) | |
| download | linux-stable-211b4d42b70f1c1660feaa968dac0efc2a96ac4d.tar.gz linux-stable-211b4d42b70f1c1660feaa968dac0efc2a96ac4d.tar.bz2 linux-stable-211b4d42b70f1c1660feaa968dac0efc2a96ac4d.zip | |
tty: fix memory leak in vc_deallocate
syzbot reported memory leak in tty/vt.
The problem was in VT_DISALLOCATE ioctl cmd.
After allocating unimap with PIO_UNIMAP it wasn't
freed via VT_DISALLOCATE, but vc_cons[currcons].d was
zeroed.
Reported-by: syzbot+bcc922b19ccc64240b42@syzkaller.appspotmail.com
Signed-off-by: Pavel Skripkin <paskripkin@gmail.com>
Cc: stable <stable@vger.kernel.org>
Link: https://lore.kernel.org/r/20210327214443.21548-1-paskripkin@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/tty')
| -rw-r--r-- | drivers/tty/vt/vt.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/tty/vt/vt.c b/drivers/tty/vt/vt.c index d9366da51e06..01645e87b3d5 100644 --- a/drivers/tty/vt/vt.c +++ b/drivers/tty/vt/vt.c @@ -1381,6 +1381,7 @@ struct vc_data *vc_deallocate(unsigned int currcons) atomic_notifier_call_chain(&vt_notifier_list, VT_DEALLOCATE, ¶m); vcs_remove_sysfs(currcons); visual_deinit(vc); + con_free_unimap(vc); put_pid(vc->vt_pid); vc_uniscr_set(vc, NULL); kfree(vc->vc_screenbuf); |