summaryrefslogtreecommitdiffstats
path: root/drivers/usb/chipidea
diff options
context:
space:
mode:
authorLi Jun <jun.li@freescale.com>2015-10-13 18:23:31 +0800
committerPeter Chen <peter.chen@freescale.com>2015-11-18 14:07:54 +0800
commit251b3c8b57481bcecd3f753108e36e7389ce12ac (patch)
tree031e8c73808e5b50e87b5e180c426703a3c8038c /drivers/usb/chipidea
parentfacf47ee6b4d07d43c3bfd6f0762f1b28f64703a (diff)
downloadlinux-stable-251b3c8b57481bcecd3f753108e36e7389ce12ac.tar.gz
linux-stable-251b3c8b57481bcecd3f753108e36e7389ce12ac.tar.bz2
linux-stable-251b3c8b57481bcecd3f753108e36e7389ce12ac.zip
usb: chipidea: debug: disable usb irq while role switch
Since the ci->role will be set after the host role start is complete, there will be nobody cared irq during start host if usb irq enabled. This error can be reproduced on i.mx6 sololite EVK board by: 1. disable otg id irq(IDIE) and disable all real otg properties of usbotg1 in dts. 2. boot up the board with ID cable and usb device connected. 3. echo gadget > /sys/kernel/debug/ci_hdrc.0/role 4. echo host > /sys/kernel/debug/ci_hdrc.0/role 5. irq 212: nobody cared. Cc: <stable@vger.kernel.org> # v3.10+ Signed-off-by: Li Jun <jun.li@freescale.com> Signed-off-by: Peter Chen <peter.chen@freescale.com>
Diffstat (limited to 'drivers/usb/chipidea')
-rw-r--r--drivers/usb/chipidea/debug.c2
1 files changed, 2 insertions, 0 deletions
diff --git a/drivers/usb/chipidea/debug.c b/drivers/usb/chipidea/debug.c
index 080b7be3daf0..58c8485a0715 100644
--- a/drivers/usb/chipidea/debug.c
+++ b/drivers/usb/chipidea/debug.c
@@ -322,8 +322,10 @@ static ssize_t ci_role_write(struct file *file, const char __user *ubuf,
return -EINVAL;
pm_runtime_get_sync(ci->dev);
+ disable_irq(ci->irq);
ci_role_stop(ci);
ret = ci_role_start(ci, role);
+ enable_irq(ci->irq);
pm_runtime_put_sync(ci->dev);
return ret ? ret : count;