diff options
author | Hans de Goede <hdegoede@redhat.com> | 2023-03-08 16:42:42 +0100 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2023-03-09 14:39:20 +0100 |
commit | f87fb985452ab2083967103ac00bfd68fb182764 (patch) | |
tree | 35e253679dddfbe6974e5ff10b827ba31944cf46 /drivers/usb/gadget/Makefile | |
parent | fe15c26ee26efa11741a7b632e9f23b01aca4cc6 (diff) | |
download | linux-stable-f87fb985452ab2083967103ac00bfd68fb182764.tar.gz linux-stable-f87fb985452ab2083967103ac00bfd68fb182764.tar.bz2 linux-stable-f87fb985452ab2083967103ac00bfd68fb182764.zip |
usb: ucsi: Fix NULL pointer deref in ucsi_connector_change()
When ucsi_init() fails, ucsi->connector is NULL, yet in case of
ucsi_acpi we may still get events which cause the ucs_acpi code to call
ucsi_connector_change(), which then derefs the NULL ucsi->connector
pointer.
Fix this by not setting ucsi->ntfy inside ucsi_init() until ucsi_init()
has succeeded, so that ucsi_connector_change() ignores the events
because UCSI_ENABLE_NTFY_CONNECTOR_CHANGE is not set in the ntfy mask.
Fixes: bdc62f2bae8f ("usb: typec: ucsi: Simplified registration and I/O API")
Link: https://bugzilla.kernel.org/show_bug.cgi?id=217106
Cc: stable@vger.kernel.org
Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Link: https://lore.kernel.org/r/20230308154244.722337-2-hdegoede@redhat.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/usb/gadget/Makefile')
0 files changed, 0 insertions, 0 deletions