diff options
| author | Tong Tiangen <tongtiangen@huawei.com> | 2021-06-11 09:40:55 +0800 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2021-06-15 15:40:58 +0200 |
| commit | 5f4dee73a4bc25a7781a5406b49439bc640981c2 (patch) | |
| tree | 98e51e5bd19c5142372de96c370dceedde1d36a5 /drivers/usb/isp1760 | |
| parent | e90f9ceb7059518de333bf8b41c06d3dff432d3b (diff) | |
| download | linux-stable-5f4dee73a4bc25a7781a5406b49439bc640981c2.tar.gz linux-stable-5f4dee73a4bc25a7781a5406b49439bc640981c2.tar.bz2 linux-stable-5f4dee73a4bc25a7781a5406b49439bc640981c2.zip | |
usb: isp1760: Fix meaningless check in isp1763_run()
Remove attribution to retval before check, which make it completely
meaningless, and does't check what it was supposed: the return
value of the timed function to set up configuration flag.
Fixes: 60d789f3bfbb ("usb: isp1760: add support for isp1763")
Tested-by: Rui Miguel Silva <rui.silva@linaro.org>
Reviewed-by: Rui Miguel Silva <rui.silva@linaro.org>
Signed-off-by: Tong Tiangen <tongtiangen@huawei.com>
Link: https://lore.kernel.org/r/20210611014055.68551-1-tongtiangen@huawei.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/usb/isp1760')
| -rw-r--r-- | drivers/usb/isp1760/isp1760-hcd.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/drivers/usb/isp1760/isp1760-hcd.c b/drivers/usb/isp1760/isp1760-hcd.c index 016a54ea76f4..27168b4a4ef2 100644 --- a/drivers/usb/isp1760/isp1760-hcd.c +++ b/drivers/usb/isp1760/isp1760-hcd.c @@ -1648,7 +1648,6 @@ static int isp1763_run(struct usb_hcd *hcd) down_write(&ehci_cf_port_reset_rwsem); retval = isp1760_hcd_set_and_wait(hcd, FLAG_CF, 250 * 1000); up_write(&ehci_cf_port_reset_rwsem); - retval = 0; if (retval) return retval; |