diff options
| author | Uwe Kleine-König <uwe@kleine-koenig.org> | 2021-02-08 15:31:48 +0100 |
|---|---|---|
| committer | Johan Hovold <johan@kernel.org> | 2021-02-09 13:13:16 +0100 |
| commit | a54af1b7d667927162d13083a8e2d470fb8722e2 (patch) | |
| tree | 88e1b7192ece21b550e46ed94967a7487441b9ae /drivers/usb | |
| parent | 6420a569504e212d618d4a4736e2c59ed80a8478 (diff) | |
| download | linux-stable-a54af1b7d667927162d13083a8e2d470fb8722e2.tar.gz linux-stable-a54af1b7d667927162d13083a8e2d470fb8722e2.tar.bz2 linux-stable-a54af1b7d667927162d13083a8e2d470fb8722e2.zip | |
USB: serial: drop if with an always false condition
In a bus remove function the passed device is always valid, so there is
no need to check for it being NULL.
(Side note: The check for port being non-NULL is broken anyhow, because
to_usb_serial_port() is a wrapper around container_of() for a member that is
not the first one. So port can hardly become NULL.)
Signed-off-by: Uwe Kleine-König <uwe@kleine-koenig.org>
Link: https://lore.kernel.org/r/20210208143149.963644-1-uwe@kleine-koenig.org
Signed-off-by: Johan Hovold <johan@kernel.org>
Diffstat (limited to 'drivers/usb')
| -rw-r--r-- | drivers/usb/serial/bus.c | 6 |
1 files changed, 1 insertions, 5 deletions
diff --git a/drivers/usb/serial/bus.c b/drivers/usb/serial/bus.c index eb0195cf37dd..58206ef0a780 100644 --- a/drivers/usb/serial/bus.c +++ b/drivers/usb/serial/bus.c @@ -86,16 +86,12 @@ err_autopm_put: static int usb_serial_device_remove(struct device *dev) { + struct usb_serial_port *port = to_usb_serial_port(dev); struct usb_serial_driver *driver; - struct usb_serial_port *port; int retval = 0; int minor; int autopm_err; - port = to_usb_serial_port(dev); - if (!port) - return -ENODEV; - /* * Make sure suspend/resume doesn't race against port_remove. * |