diff options
| author | Schspa Shi <schspa@gmail.com> | 2022-06-29 10:29:48 +0800 |
|---|---|---|
| committer | Alex Williamson <alex.williamson@redhat.com> | 2022-06-30 11:01:14 -0600 |
| commit | 6641085e8d7b3f061911517f79a2a15a0a21b97b (patch) | |
| tree | f20b66e4a7bb9adfa519aa781f1482fba09ff6a9 /drivers/vfio | |
| parent | d1877e639bc6bf1c3131eda3f9ede73f8da96c22 (diff) | |
| download | linux-stable-6641085e8d7b3f061911517f79a2a15a0a21b97b.tar.gz linux-stable-6641085e8d7b3f061911517f79a2a15a0a21b97b.tar.bz2 linux-stable-6641085e8d7b3f061911517f79a2a15a0a21b97b.zip | |
vfio: Clear the caps->buf to NULL after free
On buffer resize failure, vfio_info_cap_add() will free the buffer,
report zero for the size, and return -ENOMEM. As additional
hardening, also clear the buffer pointer to prevent any chance of a
double free.
Signed-off-by: Schspa Shi <schspa@gmail.com>
Reviewed-by: Cornelia Huck <cohuck@redhat.com>
Link: https://lore.kernel.org/r/20220629022948.55608-1-schspa@gmail.com
Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
Diffstat (limited to 'drivers/vfio')
| -rw-r--r-- | drivers/vfio/vfio.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/vfio/vfio.c b/drivers/vfio/vfio.c index 61e71c1154be..a0fb93866f61 100644 --- a/drivers/vfio/vfio.c +++ b/drivers/vfio/vfio.c @@ -1812,6 +1812,7 @@ struct vfio_info_cap_header *vfio_info_cap_add(struct vfio_info_cap *caps, buf = krealloc(caps->buf, caps->size + size, GFP_KERNEL); if (!buf) { kfree(caps->buf); + caps->buf = NULL; caps->size = 0; return ERR_PTR(-ENOMEM); } |