diff options
| author | Uwe Kleine-König <u.kleine-koenig@pengutronix.de> | 2023-03-19 00:54:19 +0100 |
|---|---|---|
| committer | Helge Deller <deller@gmx.de> | 2023-04-24 11:48:32 +0200 |
| commit | 1fd99273942058f529b7b2821ada51e0d94aac23 (patch) | |
| tree | 44431baa42352307530fea218183dc7f1b7c9fad /drivers/video/fbdev/tcx.c | |
| parent | 7b49f61a7235813045c6adb34fdc5b5a0b7c2862 (diff) | |
| download | linux-stable-1fd99273942058f529b7b2821ada51e0d94aac23.tar.gz linux-stable-1fd99273942058f529b7b2821ada51e0d94aac23.tar.bz2 linux-stable-1fd99273942058f529b7b2821ada51e0d94aac23.zip | |
fbdev: tcx: Convert to platform remove callback returning void
The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is (mostly) ignored
and this typically results in resource leaks. To improve here there is a
quest to make the remove callback return void. In the first step of this
quest all drivers are converted to .remove_new() which already returns
void.
Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Helge Deller <deller@gmx.de>
Diffstat (limited to 'drivers/video/fbdev/tcx.c')
| -rw-r--r-- | drivers/video/fbdev/tcx.c | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/drivers/video/fbdev/tcx.c b/drivers/video/fbdev/tcx.c index f2eaf6e7fff6..fc3ac2301b45 100644 --- a/drivers/video/fbdev/tcx.c +++ b/drivers/video/fbdev/tcx.c @@ -486,7 +486,7 @@ out_err: return err; } -static int tcx_remove(struct platform_device *op) +static void tcx_remove(struct platform_device *op) { struct fb_info *info = dev_get_drvdata(&op->dev); struct tcx_par *par = info->par; @@ -497,8 +497,6 @@ static int tcx_remove(struct platform_device *op) tcx_unmap_regs(op, info, par); framebuffer_release(info); - - return 0; } static const struct of_device_id tcx_match[] = { @@ -515,7 +513,7 @@ static struct platform_driver tcx_driver = { .of_match_table = tcx_match, }, .probe = tcx_probe, - .remove = tcx_remove, + .remove_new = tcx_remove, }; static int __init tcx_init(void) |