summaryrefslogtreecommitdiffstats
path: root/drivers/video/fbdev/valkyriefb.c
diff options
context:
space:
mode:
authorThomas Zimmermann <tzimmermann@suse.de>2023-07-15 20:51:45 +0200
committerThomas Zimmermann <tzimmermann@suse.de>2023-07-24 16:50:38 +0200
commita0331a4bde9dea3dffe37b6348e6509708e42e33 (patch)
treedbd224bad8e96de05a35eb61781d68355828e4c4 /drivers/video/fbdev/valkyriefb.c
parent6304da8a91da8f09c3a649b70b49ed2090d41ade (diff)
downloadlinux-stable-a0331a4bde9dea3dffe37b6348e6509708e42e33.tar.gz
linux-stable-a0331a4bde9dea3dffe37b6348e6509708e42e33.tar.bz2
linux-stable-a0331a4bde9dea3dffe37b6348e6509708e42e33.zip
fbdev: Remove FBINFO_DEFAULT from kzalloc()'ed structs
The flag FBINFO_DEFAULT is 0 and has no effect, as struct fbinfo.flags has been allocated to zero by kzalloc(). So do not set it. Flags should signal differences from the default values. After cleaning up all occurrences of FBINFO_DEFAULT, the token will be removed. v4: * clarify commit message (Geert, Dan) v2: * fix commit message (Miguel) Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de> Acked-by: Sam Ravnborg <sam@ravnborg.org> Cc: Helge Deller <deller@gmx.de> Cc: Russell King <linux@armlinux.org.uk> Link: https://patchwork.freedesktop.org/patch/msgid/20230715185343.7193-4-tzimmermann@suse.de
Diffstat (limited to 'drivers/video/fbdev/valkyriefb.c')
-rw-r--r--drivers/video/fbdev/valkyriefb.c1
1 files changed, 0 insertions, 1 deletions
diff --git a/drivers/video/fbdev/valkyriefb.c b/drivers/video/fbdev/valkyriefb.c
index b166b7cfe0e5..fd4488777032 100644
--- a/drivers/video/fbdev/valkyriefb.c
+++ b/drivers/video/fbdev/valkyriefb.c
@@ -535,7 +535,6 @@ static int __init valkyrie_init_info(struct fb_info *info,
{
info->fbops = &valkyriefb_ops;
info->screen_base = p->frame_buffer + 0x1000;
- info->flags = FBINFO_DEFAULT;
info->pseudo_palette = p->pseudo_palette;
info->par = &p->par;
return fb_alloc_cmap(&info->cmap, 256, 0);