diff options
| author | Markus Elfring <elfring@users.sourceforge.net> | 2024-09-25 21:12:36 +0200 |
|---|---|---|
| committer | Helge Deller <deller@gmx.de> | 2024-09-26 18:20:27 +0200 |
| commit | f1ebbe4cd07d058f42174cc5b8c5efcf83de8ffa (patch) | |
| tree | 4eebf4858d3f8d97af3b5a3218242153a9032d52 /drivers/video | |
| parent | 5b97eebcce1b4f3f07a71f635d6aa3af96c236e7 (diff) | |
| download | linux-stable-f1ebbe4cd07d058f42174cc5b8c5efcf83de8ffa.tar.gz linux-stable-f1ebbe4cd07d058f42174cc5b8c5efcf83de8ffa.tar.bz2 linux-stable-f1ebbe4cd07d058f42174cc5b8c5efcf83de8ffa.zip | |
fbdev: omapfb: Call of_node_put(ep) only once in omapdss_of_find_source_for_first_ep()
An of_node_put(ep) call was immediately used after a pointer check
for a of_graph_get_remote_port() call in this function implementation.
Thus call such a function only once instead directly before the check.
This issue was transformed by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Helge Deller <deller@gmx.de>
Diffstat (limited to 'drivers/video')
| -rw-r--r-- | drivers/video/fbdev/omap2/omapfb/dss/dss-of.c | 7 |
1 files changed, 2 insertions, 5 deletions
diff --git a/drivers/video/fbdev/omap2/omapfb/dss/dss-of.c b/drivers/video/fbdev/omap2/omapfb/dss/dss-of.c index 4040e247e026..d5a43b3bf45e 100644 --- a/drivers/video/fbdev/omap2/omapfb/dss/dss-of.c +++ b/drivers/video/fbdev/omap2/omapfb/dss/dss-of.c @@ -129,12 +129,9 @@ omapdss_of_find_source_for_first_ep(struct device_node *node) return ERR_PTR(-EINVAL); src_port = of_graph_get_remote_port(ep); - if (!src_port) { - of_node_put(ep); - return ERR_PTR(-EINVAL); - } - of_node_put(ep); + if (!src_port) + return ERR_PTR(-EINVAL); src = omap_dss_find_output_by_port_node(src_port); |